Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FORMS-14013 - Fixing Dropdown that had a selected value without default/placeholder set #1199

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

TalmizAhmed
Copy link
Contributor

Description & Screenshots of the change are present in the jira comment
https://jira.corp.adobe.com/browse/FORMS-14013

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 93 100 100 73

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@7851278). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev    #1199   +/-   ##
======================================
  Coverage       ?   80.81%           
  Complexity     ?      782           
======================================
  Files          ?       91           
  Lines          ?     2116           
  Branches       ?      286           
======================================
  Hits           ?     1710           
  Misses         ?      252           
  Partials       ?      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TalmizAhmed TalmizAhmed merged commit 63e3561 into dev Apr 23, 2024
11 checks passed
@TalmizAhmed TalmizAhmed deleted the dropd_fix branch April 23, 2024 04:23
rismehta added a commit that referenced this pull request Apr 23, 2024
@TalmizAhmed TalmizAhmed restored the dropd_fix branch April 23, 2024 05:28
@TalmizAhmed
Copy link
Contributor Author

Created new PR with test cases: #1203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants