Read-only is not working in file-attachment #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
pavi41
force-pushed
the
core/file-attach
branch
from
208825c
to
ded2602
Compare
github-actions
bot
force-pushed
the
core/file-attach
branch
from
ded2602
to
dcb2a9c
Compare
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
4 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1200 +/- ##
=========================================
Coverage 80.81% 80.81%
Complexity 782 782
=========================================
Files 91 91
Lines 2116 2116
Branches 286 286
=========================================
Hits 1710 1710
Misses 252 252
Partials 154 154 ☔ View full report in Codecov by Sentry. |
rismehta
requested changes
Apr 23, 2024
pavi41
force-pushed
the
core/file-attach
branch
from
dcb2a9c
to
1912845
Compare
github-actions
bot
force-pushed
the
core/file-attach
branch
from
1912845
to
c619810
Compare
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
rismehta
reviewed
Apr 25, 2024
| @@ -86,6 +86,19 @@ | |||
| return this.element.querySelector(FileInputV2.selectors.attachButtonLabel); | |||
| } | |||
|
|
|||
| updateEnabled(enabled, state) { | |||
There was a problem hiding this comment.
updateEnabled(enabled, state) {
// Update data attribute for enabled state
this.element.setAttribute(FormView.Constants.DATA_ATTRIBUTE_ENABLED, enabled);
// Determine if the widget should be disabled
const isDisabled = !enabled || state.readOnly;
// Update the 'disabled' and ARIA 'disabled' attributes based on the enabled state
if (isDisabled) {
this.widget.setAttribute("disabled", "disabled");
this.widget.setAttribute(FormView.Constants.ARIA_DISABLED, "true");
} else {
this.widget.removeAttribute("disabled");
this.widget.removeAttribute(FormView.Constants.ARIA_DISABLED);
}
}
Always try to create a constant inside the if condition to make the code more readable
There was a problem hiding this comment.
sure, implemented the same
rismehta
reviewed
Apr 25, 2024
| @@ -84,7 +84,6 @@ | |||
| } | |||
|
|
|||
| updateEnabled(enabled, state) { | |||
| this.toggle(enabled, FormView.Constants.ARIA_DISABLED, true); | |||
There was a problem hiding this comment.
Why is this code removed ? Isn't this backward incompatible
There was a problem hiding this comment.
This line was adding aria-disabled attribute to the parent div which is of no use, so I had removed this line.
pavi41
force-pushed
the
core/file-attach
branch
from
c619810
to
6ae4ae0
Compare
github-actions
bot
force-pushed
the
core/file-attach
branch
from
6ae4ae0
to
40371fb
Compare
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
rismehta
requested changes
Apr 29, 2024
| @@ -80,7 +80,7 @@ describe("Form with File Input - Basic Tests", () => { | |||
| const checkHTML = (id, state) => { | |||
| const visible = state.visible; | |||
| const passVisibleCheck = `${visible === true ? "" : "not."}be.visible`; | |||
| const passDisabledAttributeCheck = `${state.enabled === false ? "" : "not."}have.attr`; | |||
| const passDisabledAttributeCheck = `${state.enabled === false || state.readOnly === true ? "" : "not."}have.attr`; | |||
There was a problem hiding this comment.
As discussed in the scrum, can you please add the same check in all the test specs for all the components ?
There was a problem hiding this comment.
Sure Rishi, Will be adding the test cases in the next pr which I am working on for tnc component
github-actions bot
pushed a commit
that referenced
this pull request
May 3, 2024
Co-authored-by: Pavitra Khatri <pavitrakhatri@pavitras-mbp.corp.adobe.com>
github-actions bot
pushed a commit
that referenced
this pull request
May 7, 2024
Co-authored-by: Pavitra Khatri <pavitrakhatri@pavitras-mbp.corp.adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: