Read-only is not working in file-attachment

adobe · Apr 23, 2024 · ded2602 · ded2602
1 parent 7851278
commit ded2602
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 6 deletions.
diff --git a/...fd/components/form/checkboxgroup/v1/checkboxgroup/clientlibs/site/js/checkboxgroupview.js b/...fd/components/form/checkboxgroup/v1/checkboxgroup/clientlibs/site/js/checkboxgroupview.js
@@ -156,7 +156,6 @@
         }
 
         updateEnabled(enabled, state) {
-            this.toggle(enabled, FormView.Constants.ARIA_DISABLED, true);
             this.element.setAttribute(FormView.Constants.DATA_ATTRIBUTE_ENABLED, enabled);
             let widgets = this.widget;
             widgets.forEach(widget => {

diff --git a/...root/apps/core/fd/components/form/dropdown/v1/dropdown/clientlibs/site/js/dropdownview.js b/...root/apps/core/fd/components/form/dropdown/v1/dropdown/clientlibs/site/js/dropdownview.js
@@ -84,7 +84,6 @@
         }
 
         updateEnabled(enabled, state) {
-            this.toggle(enabled, FormView.Constants.ARIA_DISABLED, true);
             this.element.setAttribute(FormView.Constants.DATA_ATTRIBUTE_ENABLED, enabled);
             let widget = this.widget;
             if (enabled === false) {

diff --git a/...t/apps/core/fd/components/form/fileinput/v2/fileinput/clientlibs/site/js/fileinputview.js b/...t/apps/core/fd/components/form/fileinput/v2/fileinput/clientlibs/site/js/fileinputview.js
@@ -86,6 +86,19 @@
             return this.element.querySelector(FileInputV2.selectors.attachButtonLabel);
         }
 
+        updateEnabled(enabled, state) {
+            if (this.widget) {
+                this.element.setAttribute(FormView.Constants.DATA_ATTRIBUTE_ENABLED, enabled);
+                if (enabled === false || state.readOnly === true) {
+                    this.widget.setAttribute("disabled", "disabled");
+                    this.widget.setAttribute(FormView.Constants.ARIA_DISABLED, true);
+                } else {
+                    this.widget.removeAttribute("disabled");
+                    this.widget.removeAttribute(FormView.Constants.ARIA_DISABLED);
+                }
+            }
+        }
+
         updateValue(value) {
             if (this.widgetObject == null) {
                 this.widgetObject = new FileInputWidget(this.widgetFields);

diff --git a/.../core/fd/components/form/radiobutton/v1/radiobutton/clientlibs/site/js/radiobuttonview.js b/.../core/fd/components/form/radiobutton/v1/radiobutton/clientlibs/site/js/radiobuttonview.js
@@ -94,7 +94,6 @@
         }
 
         updateEnabled(enabled, state) {
-            this.toggle(enabled, FormView.Constants.ARIA_DISABLED, true);
             this.element.setAttribute(FormView.Constants.DATA_ATTRIBUTE_ENABLED, enabled);
             let widgets = this.widget;
             widgets.forEach(widget => {
@@ -110,7 +109,7 @@
             });
         }
 
-        updateReadOnly(readonly, state) {
+        updateReadOnly(readonly) {
             let widgets = this.widget;
             this.element.setAttribute(FormView.Constants.DATA_ATTRIBUTE_READONLY, readonly);
             widgets.forEach(widget => {

diff --git a/ui.frontend/src/view/FormFieldBase.js b/ui.frontend/src/view/FormFieldBase.js
@@ -415,7 +415,6 @@ class FormFieldBase extends FormField {
      */
     updateEnabled(enabled, state) {
         if (this.widget) {
-            this.toggle(enabled, Constants.ARIA_DISABLED, true);
             this.element.setAttribute(Constants.DATA_ATTRIBUTE_ENABLED, enabled);
             if (enabled === false) {
                 this.widget.setAttribute("disabled", "disabled");
@@ -432,7 +431,7 @@ class FormFieldBase extends FormField {
      * @param {boolean} readOnly - The read-only state.
      * @param {Object} state - The state object.
      */
-    updateReadOnly(readOnly, state) {
+    updateReadOnly(readOnly) {
         if (this.widget) {
             this.element.setAttribute(Constants.DATA_ATTRIBUTE_READONLY, readOnly);
             if (readOnly === true) {