Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eds semantic html without a separate selector #1194
eds semantic html without a separate selector #1194
Changes from 1 commit
d1ac8dc
038043b
3d3bd99
f1063aa
ef14c68
0e872ab
3aac04d
254b89a
60a299a
a73233c
9d478c1
deb1ea7
d7e9474
1c50447
8bd84d7
136b965
aca88b9
04527a8
7873513
331b24e
c8fd6cb
3847748
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 372 in bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/internal/models/v2/form/FormContainerImpl.java
Codecov / codecov/patch
bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/internal/models/v2/form/FormContainerImpl.java#L372
Check warning on line 375 in bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/internal/models/v2/form/FormContainerImpl.java
Codecov / codecov/patch
bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/internal/models/v2/form/FormContainerImpl.java#L374-L375
Check warning on line 382 in bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/internal/models/v2/form/FormContainerImpl.java
Codecov / codecov/patch
bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/internal/models/v2/form/FormContainerImpl.java#L377-L382
Check warning on line 397 in bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/internal/models/v2/form/FormContainerImpl.java
Codecov / codecov/patch
bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/internal/models/v2/form/FormContainerImpl.java#L397
Check warning on line 368 in bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/FormContainer.java
Codecov / codecov/patch
bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/FormContainer.java#L368
Check warning on line 380 in bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/FormContainer.java
Codecov / codecov/patch
bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/FormContainer.java#L380
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to use boolean primitive and return false by default