eds semantic html without a separate selector #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalagari
reviewed
Apr 16, 2024
| @Nullable | ||
| @JsonIgnore | ||
| default Boolean isEdgeDeliveryRequest() { | ||
| return null; |
There was a problem hiding this comment.
Better to use boolean primitive and return false by default
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1194 +/- ##
============================================
+ Coverage 80.89% 81.32% +0.42%
- Complexity 791 805 +14
============================================
Files 92 93 +1
Lines 2146 2163 +17
Branches 292 293 +1
============================================
+ Hits 1736 1759 +23
+ Misses 253 251 -2
+ Partials 157 153 -4 ☔ View full report in Codecov by Sentry. |
deepprakash345
changed the title
vdua
reviewed
Apr 18, 2024
ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/page/v1/page/body.html
Outdated
Show resolved
Hide resolved
nit23uec
reviewed
Apr 19, 2024
ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/page/v1/page/body.html
Outdated
Show resolved
Hide resolved
nit23uec
reviewed
Apr 19, 2024
bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/FormContainer.java
Outdated
Show resolved
Hide resolved
nit23uec
reviewed
Apr 19, 2024
...t/java/com/adobe/cq/forms/core/components/internal/models/v2/form/FormContainerImplTest.java
Outdated
Show resolved
Hide resolved
nit23uec
reviewed
Apr 19, 2024
.../main/content/jcr_root/apps/forms-components-examples/components/form/container/.content.xml
Outdated
Show resolved
Hide resolved
nit23uec
reviewed
Apr 19, 2024
...src/main/content/jcr_root/apps/core/fd/components/form/container/v2/container/container.html
Show resolved
Hide resolved
github-actions
bot
force-pushed
the
FormContainerEds
branch
from
f1063aa
to
254b89a
Compare
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
rismehta
reviewed
Apr 22, 2024
.../main/java/com/adobe/cq/forms/core/components/internal/models/v2/form/FormContainerImpl.java
Outdated
Show resolved
Hide resolved
rismehta
reviewed
Apr 22, 2024
.../main/java/com/adobe/cq/forms/core/components/internal/models/v2/form/FormContainerImpl.java
Outdated
Show resolved
Hide resolved
added 2 commits
April 25, 2024 15:07
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
rismehta
reviewed
May 7, 2024
rismehta
reviewed
May 7, 2024
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * |
There was a problem hiding this comment.
Please change the spec to pagev2.runtime.spec.js
rismehta
reviewed
May 7, 2024
| --> | ||
| Adaptive Form Core Page (v1) | ||
| ==== | ||
| Adaptive Form Core Page component v1 which extends the wcm v3 [Page](https://github.com/adobe/aem-core-wcm-components/tree/d50ba1cb0d6544870daff71281bf9dfd3f6fbeb0/content/src/content/jcr_root/apps/core/wcm/components/page/v3/page) Component. |
There was a problem hiding this comment.
The reference does not point to master branch, please change link
There was a problem hiding this comment.
main branch link added
rismehta
reviewed
May 7, 2024
| --> | ||
| Adaptive Form Core Page (v1) | ||
| ==== | ||
| Adaptive Form Core Page component v1 which extends the wcm v3 [Page](https://github.com/adobe/aem-core-wcm-components/tree/d50ba1cb0d6544870daff71281bf9dfd3f6fbeb0/content/src/content/jcr_root/apps/core/wcm/components/page/v3/page) Component. |
There was a problem hiding this comment.
you don't need to mention the specific version of WCM core component
There was a problem hiding this comment.
version removed
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
rismehta
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tainerEds].....
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: