Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpecialFacetedSearch, refs 4611 #4663

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add SpecialFacetedSearch, refs 4611 #4663

wants to merge 1 commit into from

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Mar 22, 2020

This PR is made in reference to: #4611

This PR addresses or contains:

  • General introduction [0]
  • FACETEDSEARCH_PROFILE_SCHEMA description [1]
  • range_group and range_control specific description [2]

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes: #4611

[0] https://github.com/SemanticMediaWiki/SemanticMediaWiki/tree/faceted-search/src/MediaWiki/Specials/FacetedSearch
[1] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/faceted-search/src/Schema/docs/facetedsearch.profile.md
[2] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/faceted-search/src/Schema/docs/property.profile.md

@mwjames
Copy link
Contributor Author

mwjames commented Mar 22, 2020

The default profile (deployed with SMW) will provide a minimum set of settings to make the faceted search to appear light without any fancy sliders, hierarchy trees, checkboxes, or conditional fields.

image

Custom profile

A custom profile can alter the appearance by adding a theme that controls a CSS set (stored via Common.css etc.) providing a possibility to make the sidebar wider (or generally occupy 100% width) or to modify the color scheme as demonstrated below.

image

There are couple of different value filters available to make the filtering process more adaptable to the context of values so for example, a range filter for numeric values:

image

A range group filter with range groups being maintained on the selected property (as those ranges are context driven by the related property hence they need to be assigned to the property via a PROPERTY_PROFILE_SCHEMA)

image

Support for a hierarchy_tree to be shown as part of the category and property filter card (as demonstrated above) or instead of the default list_filter select a checkbox_filter.

image

@mwjames
Copy link
Contributor Author

mwjames commented Mar 22, 2020

There is a possibility to enable other result printers such as map (as demonstrated below) but that isn't part of the initial deployment and it should be checked whether it makes sense to provide other printers based on use case and merit.

I only have spent 10 minutes on this but ProfessionalWiki/Maps#609 and ProfessionalWiki/Maps#608 are a related outcome of this experiment.

image

@kghbln kghbln added the wikidocu missing Code changes (mostly features) what have not yet been documented label Mar 22, 2020
@gesinn-it-gea gesinn-it-gea mentioned this pull request Mar 29, 2020
@akuckartz
Copy link

Is the missing documentation the only reason why this is not yet merged?

@JeroenDeDauw JeroenDeDauw added enhancement Alters an existing functionality or behaviour new feature A new, or altered behaviour of an existing functionality that fundamentally impacts behaviour and removed enhancement Alters an existing functionality or behaviour labels Aug 10, 2020
@kghbln
Copy link
Member

kghbln commented Aug 22, 2020

Is the missing documentation the only reason why this is not yet merged?

No, this pull also has conflicts with master which need to be resolved. It is save to say that this will unfortunately not make it into 3.2.x

@kghbln kghbln added this to the SMW 3.3.0 milestone Aug 22, 2020
@kghbln kghbln removed the wikidocu missing Code changes (mostly features) what have not yet been documented label Aug 22, 2020
@akuckartz
Copy link

@mwjames Can you have a look at the conflicts?

@gesinn-it-gea
Copy link
Member

gesinn-it-gea commented Nov 23, 2021

@JeroenDeDauw @kghbln @krabina @hexmode @akuckartz (and others): shouldn't we make a joint effort to finish the incredible work that @mwjames has done in this PR, #4611 and related commits to get Faceted Search into 4.0.0?

@kghbln
Copy link
Member

kghbln commented Nov 23, 2021

Personally I'd rather get 4.0.0 to the public to support 1.36 and perhaps 1.37 sooner than later. I am afraid that making this faceted search happen will add a delay to the release. I have nothing against doing a 4.1.0 release soon after if someone finishes the coolness of this PR. Anyhow the developers have to do the work.

@krabina
Copy link
Contributor

krabina commented Nov 23, 2021

I agree that this PR shoud be finished! Personally, I don't care so much about in between LTS releases. From a dev point of view I can image that it might be easier to make this work in 1.35 and then care for this (and other issues) in 1.36 and 1.37. Otherwise we might keep this lying around way longer, making it harder to get it to work in a later release.

But I agree with Karsten, the devs who will take this on will have the decision.

@JeroenDeDauw
Copy link
Member

@gesinn-it-gea be my guest. I do not have sufficient incentives to look into this feature and do not expect that to change.

@kghbln kghbln removed this from the SMW 4.0.0 milestone Jan 18, 2022
@krabina
Copy link
Contributor

krabina commented Oct 28, 2022

@gesinn-it-gea what must be done to accept/test this? How can we help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature A new, or altered behaviour of an existing functionality that fundamentally impacts behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faceted search
6 participants