-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SpecialFacetedSearch
, refs 4611
#4663
base: master
Are you sure you want to change the base?
Conversation
The default profile (deployed with SMW) will provide a minimum set of settings to make the faceted search to appear light without any fancy sliders, hierarchy trees, checkboxes, or conditional fields. Custom profileA custom profile can alter the appearance by adding a There are couple of different value filters available to make the filtering process more adaptable to the context of values so for example, a range filter for numeric values: A range group filter with range groups being maintained on the selected property (as those ranges are context driven by the related property hence they need to be assigned to the property via a Support for a |
There is a possibility to enable other result printers such as I only have spent 10 minutes on this but ProfessionalWiki/Maps#609 and ProfessionalWiki/Maps#608 are a related outcome of this experiment. |
Is the missing documentation the only reason why this is not yet merged? |
No, this pull also has conflicts with master which need to be resolved. It is save to say that this will unfortunately not make it into 3.2.x |
@mwjames Can you have a look at the conflicts? |
@JeroenDeDauw @kghbln @krabina @hexmode @akuckartz (and others): shouldn't we make a joint effort to finish the incredible work that @mwjames has done in this PR, #4611 and related commits to get Faceted Search into 4.0.0? |
Personally I'd rather get 4.0.0 to the public to support 1.36 and perhaps 1.37 sooner than later. I am afraid that making this faceted search happen will add a delay to the release. I have nothing against doing a 4.1.0 release soon after if someone finishes the coolness of this PR. Anyhow the developers have to do the work. |
I agree that this PR shoud be finished! Personally, I don't care so much about in between LTS releases. From a dev point of view I can image that it might be easier to make this work in 1.35 and then care for this (and other issues) in 1.36 and 1.37. Otherwise we might keep this lying around way longer, making it harder to get it to work in a later release. But I agree with Karsten, the devs who will take this on will have the decision. |
@gesinn-it-gea be my guest. I do not have sufficient incentives to look into this feature and do not expect that to change. |
@gesinn-it-gea what must be done to accept/test this? How can we help? |
This PR is made in reference to: #4611
This PR addresses or contains:
FACETEDSEARCH_PROFILE_SCHEMA
description [1]range_group
andrange_control
specific description [2]This PR includes:
Fixes: #4611
[0] https://github.com/SemanticMediaWiki/SemanticMediaWiki/tree/faceted-search/src/MediaWiki/Specials/FacetedSearch
[1] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/faceted-search/src/Schema/docs/facetedsearch.profile.md
[2] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/faceted-search/src/Schema/docs/property.profile.md