[FacetedSearch] Updates for SMW 4.1.3

[YOUR1]

This #4663 was an old MR by James. I think this is quite valuable, so I made sure that his code isn't lost and made it working on 4.1.3.

[coderabbitai]

Important

Review Skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

31 files out of 86 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[jaideraf]

Thank you @YOUR1, this is quite valuable indeed. Could you look at the failing tests here on the GitHub?

[YOUR1]

Thank you @YOUR1, this is quite valuable indeed. Could you look at the failing tests here on the GitHub?

Took some commits (long live sleep deprivation) - but here you go.

[YOUR1]

@JeroenDeDauw I'm not quite sure why one check is skipped and one cancelled. Can you recheck?

[jaideraf]

Very interesting functionality! 👍🏼 I tested and generally it works (it requires the update.php). Just the export feature that is not working (the JSON, CSV and RDF export):

https://wikincat.org/w/index.php?title=Special:FacetedSearch&q=%5B%5BCategory%3AObra%5D%5D&profile=work&uselang=en

I wish I could hide some administrative properties from the filters, I don't know how to do it yet.
@kghbln @krabina take a look.

[YOUR1]

Very interesting functionality! 👍🏼 I tested and generally it works (it requires the update.php). Just the export feature that is not working (the JSON, CSV and RDF export):

https://wikincat.org/w/index.php?title=Special:FacetedSearch&q=%5B%5BCategory%3AObra%5D%5D&profile=work&uselang=en

I wish I could hide some administrative properties from the filters, I don't know how to do it yet. @kghbln @krabina take a look.

The export functionality is working fine on my side, can you give me more info about the error you are encountering?

[krabina]

Interesting. I found a page showing some help information: https://wikincat.org/wiki/Especial:FacetedSearch?profile=default&q=&utf8=%E2%9C%93&limit=0&offset=0&csum=

The thiing is: this is an even more complex interface then Special:aAsk. So it is not so much for the end user, but for SMW professionals. Which is fine, but I thought that faceted search would build on full-text search that cen be narrowed down based on facets. Something like this: https://www.mediawiki.org/wiki/Extension:WikiSearchFront

[jaideraf]

The export functionality is working fine on my side, can you give me more info about the error you are encountering?

Indeed. In Firefox it is working fine, but in Chrome the console says:

I don't know, maybe it is something wrong with my side (https/network/redirects...). Thank you.

[YOUR1]

The export functionality is working fine on my side, can you give me more info about the error you are encountering?

Indeed. In Firefox it is working fine, but in Chrome the console says:

I don't know, maybe it is something wrong with my side (https/network/redirects...). Thank you.

This looks more like a misconfiguration on the server side tbh. Perhaps your wiki is configured on http:// instead of https://.

[jaideraf]

Perhaps your wiki is configured on http:// instead of https://.

Wow, just exactly that. Just changed $wgServer = "http://wikincat.org"; to $wgServer = "https://wikincat.org"; and the problem is gone. 👍🏼

[krabina]

So it seems to be working fine? Since it is a new feature it is not breakting anything. Basically we could go ahead an merge this. Any objections?