Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix]: Add ruturn value check for fs_unlink and ta_storage_cmd_unlink #743

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[BugFix]: Add ruturn value check for fs_unlink and ta_storage_cmd_unlink #743

wants to merge 6 commits into from

Conversation

XMPengYinjie
Copy link

[Desc]:

  1. check_storage_available should check fs_unlink's return value.
  2. ta_storage_cmd_unlink should't always return TEE_SUCCESS.

@XMPengYinjie
[BugFix]: Add ruturn value check for fs_unlink
94f5830 
[Desc]:
1. check_storage_available should check fs_unlink's return value;
2. ta_storage_cmd_unlink should't always return TEE_SUCCESS;

Signed-off-by: pengyinjie <pengyinjie@xiaomi.com>
@XMPengYinjie XMPengYinjie mentioned this pull request Apr 25, 2024
Open
jenswi-linaro
jenswi-linaro reviewed Apr 29, 2024
View reviewed changes
ta/storage/storage.c Outdated Show resolved Hide resolved
host/xtest/regression_6000.c Show resolved Hide resolved
XMPengYinjie and others added 2 commits May 14, 2024 11:23
@XMPengYinjie
Merge branch 'OP-TEE:master' into master
54263d9
@XMPengYinjie
[BugFix]: Add ruturn value check for fs_unlink
a26fbfa 
[Desc]:
1. check_storage_available should check fs_unlink's return value;
2. ta_storage_cmd_unlink should't always return TEE_SUCCESS;

Signed-off-by: pengyinjie <pengyinjie@xiaomi.com>
@jenswi-linaro
Copy link
Contributor

Please squash all the changes into one commit.

etienne-lms
etienne-lms reviewed May 14, 2024
View reviewed changes
ta/storage/storage.c Outdated Show resolved Hide resolved
@XMPengYinjie
[BugFix]: Add ruturn value check for fs_unlink
fdc8c94 
[Desc]:
1. check_storage_available should check fs_unlink's return value;
2. ta_storage_cmd_unlink should't always return TEE_SUCCESS;

Signed-off-by: pengyinjie <pengyinjie@xiaomi.com>
@XMPengYinjie
[BugFix]: Add ruturn value check for fs_unlink
957eff6 
[Desc]:
1. check_storage_available should check fs_unlink's return value;
2. ta_storage_cmd_unlink should't always return TEE_SUCCESS;

Signed-off-by: pengyinjie <pengyinjie@xiaomi.com>
@XMPengYinjie
[BugFix]: Add ruturn value check for fs_unlink
e28cc9b 
[Desc]:
1. check_storage_available should check fs_unlink's return value;
2. ta_storage_cmd_unlink should't always return TEE_SUCCESS;

Signed-off-by: pengyinjie <pengyinjie@xiaomi.com>
@XMPengYinjie
Copy link
Author

XMPengYinjie commented May 16, 2024 •
edited

Please squash all the changes into one commit.

Do I need create a new RP when this RP finished?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenswi-linaro jenswi-linaro jenswi-linaro left review comments

@etienne-lms etienne-lms etienne-lms left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@XMPengYinjie @jenswi-linaro @etienne-lms