Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing return value check when use fs_unlink func. #742

Open
XMPengYinjie opened this issue Apr 25, 2024 · 3 comments
Open

Missing return value check when use fs_unlink func. #742

XMPengYinjie opened this issue Apr 25, 2024 · 3 comments

Comments

@XMPengYinjie
Copy link

Hi supporter:

As title, in host/xtest/regression_6000.c should check fs_unlink 's return value :
image

Also in ta/storage/storage.c ta_storage_cmd_unlink should't alway rerurn TEE_SUCCESS.
image

I have tried as follow patch, could you please help to double check ?
image
image

@XMPengYinjie
Copy link
Author

Now check_storage_available will return TEE_SUCCESS even though fs_unlink--->ta_storage_cmd_unlink failed early in TEE.

@jenswi-linaro
Copy link
Contributor

Please propose the patch in a pull request for easier reviewing.

@XMPengYinjie
Copy link
Author

Please propose the patch in a pull request for easier reviewing.

Hi jenswi-linaro:
As your comment, pelease help to review the pull reques:

#743

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants