Updates for the new 'imp' field in TEEC_Session and TEEC_Context #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the test xtest_tee_test_1025() uses a part of a struct from tee_client_api.h that is implementation defined, the test needed to be updated when the implementation defined parts of the structs in tee_client_api.h changed to use an imp field instead of separate fields. Signed-off-by: Julianus Larson <julianus.larson@linaro.org> Reported-by: Tom Hebb <tommyhebb@gmail.com> Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
|
Can someone please review the second commit ("gp: update API files to use the imp field in TEEC_Session")? With this I checked that all tests (including the GP suite) build and pass on QEMUv8. It would be nice to include the OP-TEE client update in the coming release. |
|
|
The OP-TEE client library has been updated to include an 'imp' field as required by the GlobalPlatform specification. Therefore, update the parts of the code that access the TEE context which is now inside this 'imp' struct. This commit is the result of the following commands: sed -i 's/sess->ctx/sess->imp.ctx/' $(git grep -l 'sess->ctx') sed -i 's/s->ctx/s->imp.ctx/' $(git grep -l 's->ctx') Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
jforissier
force-pushed
the
optee_client_imp
branch
from
73cfc31
to
ebbb2fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on (and is required due to) OP-TEE/optee_client#349.