regression_1025: use the imp field in TEEC_Context #684
Conversation
|
|
|
In the commit description: add missing parentheses after the function name: |
|
|
|
This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note that you can always re-open a closed pull request at any time. |
|
This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note that you can always re-open a closed pull request at any time. |
|
This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note that you can always re-open a closed pull request at any time. |
|
Ping @JLLinaro ? |
JLLinaro
force-pushed
the
fix_imp_part_of_types_in_tee_client_api
branch
from
6b38904
to
92d96de
Compare
Sorry, but now it has been fixed. |
|
Better to use the imperative mood ("Update tests...") rather than the past tense ("Updated tests..."). Other than that this is fine:
Since there is a dependency on OP-TEE/optee_client#349 I will merge this when both are ready. Thanks! |
|
This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note that you can always re-open a closed pull request at any time. |
|
@JLLinaro please update the commit subject as requested and add the Acked-by: and Reviewed-by: tags given above. Thanks! |
|
This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note that you can always re-open a closed pull request at any time. |
As the test xtest_tee_test_1025() uses a part of a struct from tee_client_api.h that is implementation defined, the test needed to be updated when the implementation defined parts of the structs in tee_client_api.h changed to use an imp field instead of separate fields. Signed-off-by: Julianus Larson <julianus.larson@linaro.org> Reported-by: Tom Hebb <tommyhebb@gmail.com> Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
JLLinaro
force-pushed
the
fix_imp_part_of_types_in_tee_client_api
branch
from
92d96de
to
9afc5e5
Compare
|
@JLLinaro please make the subject "regression_1025: use the imp field in TEEC_Context". I'll pick that and create a new pull request because some GP files need to be adapted, too. Thanks! |
JLLinaro
changed the title
As the test xtest_tee_test_1025 uses a part of a struct from tee_client_api.h that is implementation defined, the test needed to be updated when the implementation defined parts of the structs in tee_client_api.h changed to use an imp field instead of separate fields.
Link: OP-TEE/optee_client#349
Reported-by: Tom Hebb tommyhebb@gmail.com
Signed-off-by: Julianus Larson julianus.larson@linaro.org