Update to Net-standard 2.1 and update test project NuGet packages #3008
Conversation
…yzers AsyncUsageAnalyser is not under active maintaince and it's kinda deprecated and has not updated since years. Microsoft.VisualStudio.Threading.Analyzers is added as an replacement for it. This might cause new warnings. NancyFx#3007
XUnit from alpha to 4.1, FakeItEasy from 4 to 6 and Microsoft.Net.Test.Sdk from 15.5.0 to 16.5.0 NancyFx#3007
|
Builds are failing on Travis and AppVeyor because of the .NET SDK and Mono version. I need to see how to fix them. |
xunit.runner.visualstudio (2.4.1) will run the jobs for dotnet test command. Microsoft.NET.Test.Sdk version changed to 15.5.0 from 16.5.0. The 16.5.0 version didn't copy testhost.dll to the output. NancyFx#3007
- Travis-ci: Distro has changed to Ubuntu bionic, Mono changed to 6.8.0 and dotnet sdk to 3.1.102 - Appveyor: image changed to VS2019 - PowerShell script: CakeVersion updated to 0.37.0 - Bash script: DOTNET_INSTALL_URL updated - For both powershell and bash, there was a bug in regex that couldn't detect versions like x.x.x00. - Cake: The project is using `dotnet test` command. `xunit` command replaced with `test` command and arguments chagned to match dotnet test command. NancyFx#3007
AppVeyor pipeline is passing now, there is a problem with Travis in OSXand Linux. I need to investigate more. |
|
There is something interesting, Travis CI now supports .NET SDK 3.x.x by default. Why do we need to install it again? |
0x414c49
force-pushed
the
dotnet-standard-2.1
branch
from
6530c7f
to
4048bf4
Compare
|
By replacing |
|
The pipelines now compile fine. The tests are running fine Linux, OSX and on a local-machine. |
|
I don't know why. I have a parallel test on my own AppVeyor account. The tests are passing fine there!
|
0x414c49
force-pushed
the
dotnet-standard-2.1
branch
from
4048bf4
to
6fd4133
Compare
|
By rerunning the build, everything works fine. |
|
Why target .NET Standard 2.1? Nancy's not using any APIs from the standard. I'm failing to see what value it brings. |
|
@khellang you are right about the |
Prerequisites
Description
The projects are targeted to .NET Standard 2.1, 2.0 and .NET 4.5.2. Due to this change minimum version of the SDK project changed to
3.1.102->rollForward minor.The
AsyncUsageAnalyzersis not supported in .NET Standard 2.1 and it's outdated. I replaced it withMicrosoft.VisualStudio.Threading.Analyzerspackage.FakeItEasy, XUnit and Microsoft Test Framework SDK are updated to the latest version.
This PR will resolve #3007