Skip to content
This repository has been archived by the owner on Jan 24, 2021. It is now read-only.

Target .NET Standard 2.1 #3007

Open
4 tasks done
0x414c49 opened this issue Mar 11, 2020 · 1 comment · May be fixed by #3008
Open
4 tasks done

Target .NET Standard 2.1 #3007

0x414c49 opened this issue Mar 11, 2020 · 1 comment · May be fixed by #3008

Comments

@0x414c49
Copy link

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am running the latest version of Nancy
  • I have verified if the problem exist in both DEBUG and RELEASE mode
  • I have searched open and closed issues to ensure it has not already been reported

Description

At the moment NancyFX only targets .NET Standard 2.0 and .NET 4.5.2. Since .NET Standard 2.1 is out, we can target the project for .NET Standrd 2.1.
0x414c49 pushed a commit to 0x414c49/Nancy that referenced this issue Mar 11, 2020
Add .NET Standard 2.1 support to the projects
0d12681 
NancyFx#3007
0x414c49 pushed a commit to 0x414c49/Nancy that referenced this issue Mar 11, 2020
Change SDK version to 3.0.100 to support .NET Standard 2.1
18f1482 
NancyFx#3007
0x414c49 pushed a commit to 0x414c49/Nancy that referenced this issue Mar 11, 2020
Support .NET Core App 3.1 for tests
0a6cce0 
NancyFx#3007
0x414c49 pushed a commit to 0x414c49/Nancy that referenced this issue Mar 11, 2020
Replace AsyncUsageAnalyser with Microsoft.VisualStudio.Threading.Anal…
d0f2e04 
…yzers

AsyncUsageAnalyser is not under active maintaince and it's kinda deprecated and has not updated since years. Microsoft.VisualStudio.Threading.Analyzers is added as an replacement for it. This might cause new warnings.

NancyFx#3007
0x414c49 pushed a commit to 0x414c49/Nancy that referenced this issue Mar 11, 2020
Update test NuGet packages
65a3a74 
XUnit from alpha to 4.1, FakeItEasy from 4 to 6 and Microsoft.Net.Test.Sdk from 15.5.0 to 16.5.0

NancyFx#3007
@0x414c49 0x414c49 linked a pull request Mar 11, 2020 that will close this issue
Open
4 tasks
0x414c49 pushed a commit to 0x414c49/Nancy that referenced this issue Mar 12, 2020
Remove xunit.dotnet
9be3aec 
xunit.runner.visualstudio (2.4.1) will run the jobs for dotnet test command. Microsoft.NET.Test.Sdk version changed to 15.5.0 from 16.5.0. The 16.5.0 version didn't copy testhost.dll to the output.

NancyFx#3007
0x414c49 pushed a commit to 0x414c49/Nancy that referenced this issue Mar 12, 2020
Update build scripts
24ac114 
- Travis-ci: Distro has changed to Ubuntu bionic, Mono changed to 6.8.0 and dotnet sdk to 3.1.102
- Appveyor: image changed to VS2019
- PowerShell script: CakeVersion updated to 0.37.0
- Bash script: DOTNET_INSTALL_URL updated
- For both powershell and bash, there was a bug in regex that couldn't detect versions like x.x.x00.
- Cake: The project is using `dotnet test` command. `xunit` command replaced with `test` command and arguments chagned to match dotnet test command.

NancyFx#3007
0x414c49 pushed a commit to 0x414c49/Nancy that referenced this issue Mar 12, 2020
Add NetCoreApp3.1 to FluentValidTest
4048bf4 
NancyFx#3007
0x414c49 pushed a commit to 0x414c49/Nancy that referenced this issue Mar 12, 2020
Add .NETCoreApp3.1 to FluentValidTests
6fd4133 
NancyFx#3007
@0x414c49
Copy link
Author

In PR #3008, I resolved this issue. The only problem is the +500 analysis warnings for async usages.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to Net-standard 2.1 and update test project NuGet packages 0x414c49/Nancy
1 participant
@0x414c49