[WIP] New module juniper_junos_file #370
Conversation
There was a problem hiding this comment.
This code currently supports copying from the Ansible control machine to the Junos device via SCP. This is a great start because I believe it hits ~90% of the requirement. I was also hoping that this module could support the file-copy RPC so that file copies could be initiated from the Junos device and support all of the various URL formats supported by Junos.
| @@ -0,0 +1,53 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
I think this action plugin is the same as juniper_junos_common_action.py. If it is, it should be a link to juniper_junos_common_action.py rather than a copy/paste of the file. The diff doesn't make it clear if this is a file or a link, so if it's already a link, please ignore my comment.
| 'supported_by': 'community', | ||
| 'status': ['stableinterface']} | ||
|
|
||
| DOCUMENTATION = ''' |
There was a problem hiding this comment.
Please make sure the documentation for this module builds correctly before we merge. The documentation syntax is very fragile.
| ''' | ||
|
|
||
|
|
||
| def import_juniper_junos_common(): |
There was a problem hiding this comment.
This function is no longer necessary after #357 and should be removed.
|
|
||
| def main(): | ||
| # Import juniper_junos_common | ||
| juniper_junos_common = import_juniper_junos_common() |
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
I've started to work on a new module to manage file, it's based on @renetbo work in #177 and I tried to refactor to align with the new structure.
I've been using it to transfet file to/from junos devices and this part is working good so far.
I still need to do more testing but I've seen some discussions around a module like this one so I figured I would create the PR for visibility.