new scp file

[renetbo]

Hi,

I've created the junos_scp_file which sccp a file to a machine. This is necessary in fusion as you need to push a file to the Aggregation Device so that it can install it to the Satellite device (i.e. in Fusion you can't push it to the satellite and install it as you would do with junos_install_os)

Thanks

B

[dgarros]

That is awesome Thanks @renetbo , I was talking last week about that with @vnitinv, it has been suggested in #169 as well

[dgarros]

Is it possible with this module to copy a file FROM the device ? it would be super useful to collect logs for example

[renetbo]

Not as of today but change will be minimum so I will take care of it ASAP.

Boris

[renetbo]

I've updated my file in my own github to take care of put and get. I've tested it and it works ok.

[dgarros]

I don;t think you can have 2 licenses for the same file : apache 2.0 and Juniper Networks Script Software License

[dgarros]

Thanks a lot @renetbo this is gonna be very useful.
I did a quick review of the module and provided few comments inline.

Also, while reviewing it, I got couple of ideas that would make some great enhancements.
I understand these might be too much to ask you but I'm putting them here to start the discussion. If you want to give it a try that would be great.

Make the module idempotent
I understand it's more complicated but if possible it would be great to make this module idempotent.
When doing a get or a put:

• Check if the file exist before and if exist check the checksum
• After the transfer, check the checksum again

If the file has been created or changed, set the changed flag to true

Support the --check option
Based on the code for idempotency, we could just check if file exist and check the checksums to see what would be the impact of this module

[renetbo]

OK fixed./ From: Damien [mailto:notifications@github.com] Sent: Wednesday, November 23, 2016 22:26 To: Juniper/ansible-junos-stdlib <ansible-junos-stdlib@noreply.github.com> Cc: Boris Renet <brenet@juniper.net>; Mention <mention@noreply.github.com> Subject: Re: [Juniper/ansible-junos-stdlib] new scp file (#177) @dgarros commented on this pull request.

________________________________ In library/junos_scp_file<#177 (review)>:

+# derived from this software without specific prior written permission.

+# +# THIS SOFTWARE IS PROVIDED BY Juniper Networks, Inc. ''AS IS'' AND ANY +# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED +# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE +# DISCLAIMED. IN NO EVENT SHALL Juniper Networks, Inc. BE LIABLE FOR ANY +# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES +# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; +# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND +# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS +# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +# <******************* +# +# Copyright 2016 Juniper Networks, Inc. All rights reserved. I don;t think you can have 2 licenses for the same file : apache 2.0 and Juniper Networks Script Software License — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#177 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AHWR3e109UN6rSzZ3r-GWnx78edFJs7Oks5rBK9dgaJpZM4Kz8Sj>.

[renetbo]

OK I've updated the junos_scp_file so that, it can handle put, get and md5:

• PUT:
  • if file not in the source then it triggers and error and stops there
  • then it checks if file is in the destination:
    • if not: transfer file and compare the md5 of source and destination. If different then failure
    • if yes: compare the md5 of source and destination:
      • if same then don't transfer
      • if different then transfer and compare the md5 of source and destination. If different then failure
  • at the end, several options for the status:
    • error (if file was not in the source)
    • "File already present, skipping the scp"
    • "File pushed OK"
    • "Transfer failed (different MD5 between source and destination)"
• get is similar by swapping source and destination

[vnitinv]

@renetbo Thanks for this pull request.

[jeffbrl]

@vnitinv This would be very useful. Can the PR be merged?

[vnitinv]

@jeffbrl Agree. @stacywsmith whats your feedback. I think we should get in this functionality.

[stacywsmith]

I agree the functionality is useful. However, since we're in the process of a significant rewrite of the Ansible modules, I don't want to merge this just yet.

Instead, I plan on implementing a new juniper_junos_file module which incorporates this functionality (and more) and uses the new shared infrastructure.

Merging this now would mean having to maintain backwards compatibility with something that's only been around for 1 to 2 weeks. I'd rather avoid that.

[rsmekala]

@stacywsmith Ansible has implemented a module. that allows user to copy from/to Junos devices using SCP.

Currently, PyEZ supports both SCP and FTP for file transfer.

Should we go ahead with creating a new module for Juniper.junos role that supports both SCP and FTP or contribute to Ansible module by adding FTP support to junos_scp module.

[vnitinv]

@stacywsmith Any feedback on @rsmekala query?

[stacywsmith]

I personally would like to see a juniper_junos_file module which is based on the file-copy RPC. This would inherently support all protocols/URLs which are supported at the Junos CLI with the file copy command, so it would include both remote and local copies.

It would also be a copy which is initiated from the Junos device rather than from the Ansible control machine. For that reason, I believe it would be complimentary to the existing Ansible module which I believe only supports a copy from the Ansible control machine to the Junos host over SCP.

[dgarros]

I've been working on an update of this module which looks similar to what @stacywsmith is talking about
check #370

[jnpr-community-netdev]

Can one of the admins verify this patch?

[jnpr-community-netdev]

Can one of the admins verify this patch?