Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use is_juliarepr more in show.jl testing #54304

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

use is_juliarepr more in show.jl testing #54304

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e554cd6
use is_juliarepr more in testing
LilithHafner Apr 29, 2024
1a47893
rename and make `@test` errors better
LilithHafner Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/show.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ end
@test repr(:(∓ 1)) == ":(∓1)"
@test repr(:(± 1)) == ":(±1)"

is_juliarepr(x) = eval(Meta.parse(repr(x))) == x
LilithHafner marked this conversation as resolved.
Show resolved Hide resolved
for ex in [Expr(:call, :f, Expr(:(=), :x, 1)),
Expr(:ref, :f, Expr(:(=), :x, 1)),
Expr(:vect, 1, 2, Expr(:kw, :x, 1)),
Expand All @@ -260,7 +261,7 @@ for ex in [Expr(:call, :f, Expr(:(=), :x, 1)),
Expr(:call, :*, 0, :x01),
Expr(:call, :*, 0, :b01),
Expr(:call, :*, 0, :o01)]
@test eval(Meta.parse(repr(ex))) == ex
@test is_juliarepr(ex)
end

@test repr(Expr(:using, :Foo)) == ":(\$(Expr(:using, :Foo)))"
Expand Down Expand Up @@ -294,8 +295,8 @@ end
@test_repr "3:4:5"
let ex4 = Expr(:call, :(:), 1, 2, 3, 4),
ex1 = Expr(:call, :(:), 1)
@test eval(Meta.parse(repr(ex4))) == ex4
@test eval(Meta.parse(repr(ex1))) == ex1
@test is_juliarepr(ex4)
@test is_juliarepr(ex1)
end

# Complex
Expand Down Expand Up @@ -1716,7 +1717,6 @@ let x = TypeVar(:_, Number), y = TypeVar(:_, Number)
end


is_juliarepr(x) = eval(Meta.parse(repr(x))) == x
@testset "unionall types" begin
X = TypeVar(gensym())
Y = TypeVar(gensym(), Ref, Ref)
Expand Down Expand Up @@ -2199,7 +2199,7 @@ end

# issue #30927
Z = Array{Float64}(undef,0,0)
@test eval(Meta.parse(repr(Z))) == Z
@test is_juliarepr(Z)

@testset "show undef" begin
# issue #33204 - Parseable `repr` for `undef`
Expand Down Expand Up @@ -2256,7 +2256,7 @@ end

@testset "0-dimensional Array. Issue #31481" begin
for x in (zeros(Int32), collect('b'), fill(nothing), BitArray(0))
@test eval(Meta.parse(repr(x))) == x
@test is_juliarepr(x)
end
@test showstr(zeros(Int32)) == "fill(0)"
@test showstr(collect('b')) == "fill('b')"
Expand Down