use is_juliarepr more in show.jl testing
#54304
Open
+24
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilithHafner
added
test
ericphanson
reviewed
Apr 30, 2024
KristofferC
reviewed
May 2, 2024
| @@ -248,6 +248,8 @@ end | |||
| @test repr(:(∓ 1)) == ":(∓1)" | |||
| @test repr(:(± 1)) == ":(±1)" | |||
|
|
|||
| eval_parse_repr(x) = eval(Meta.parse(repr(x))) | |||
| eval_parse_repr_test(x) = @test eval_parse_repr(x) == x | |||
There was a problem hiding this comment.
This makes the line numbers reported by a test failure worse.
julia> using Test
julia> @test 1==2
Test Failed at REPL[2]:1 <---- Just entered
Expression: 1 == 2
Evaluated: 1 == 2
ERROR: There was an error during testing
julia> @test 1==3
Test Failed at REPL[3]:1 <---- Just entered
Expression: 1 == 3
Evaluated: 1 == 3
ERROR: There was an error during testing
julia> test_eq_1(x) = @test x == 1
test_eq_1 (generic function with 1 method)
julia> test_eq_1(2)
Test Failed at REPL[4]:1 <----- where function defined
Expression: x == 1
Evaluated: 2 == 1
ERROR: There was an error during testing
julia> test_eq_1(3)
Test Failed at REPL[4]:1 <----- where function defined
Expression: x == 1
Evaluated: 3 == 1
ERROR: There was an error during testing
There was a problem hiding this comment.
So just make it return a bool and add back the @test.
There was a problem hiding this comment.
We can have either line numbers or display the actual/expected values. I prefer displaying the actual/expected values (this) because we can always get line numbers from stack traces.
There was a problem hiding this comment.
What do you mean? As is, this is just worse than before. Finding the line number in the stacktrace is often not easy.
Just inline it back if it is an issue. Going around DRY-ing test code is seldom a good idea.
There was a problem hiding this comment.
What do you mean?
julia> f(x) = x == 5
f (generic function with 1 method)
julia> @test f(4)
Test Failed at REPL[15]:1
Expression: f(4)
ERROR: There was an error during testing
julia> g(x) = @test x == 5
g (generic function with 1 method)
julia> g(4)
Test Failed at REPL[16]:1
Expression: x == 5
Evaluated: 4 == 5
ERROR: There was an error during testing
KristofferC
requested changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to be used a bunch, now it's used almost always where the construct appears.