Implement a pre-build configuration process and datatype #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #929 +/- ##
==========================================
+ Coverage 84.62% 85.19% +0.57%
==========================================
Files 3 3
Lines 826 831 +5
==========================================
+ Hits 699 708 +9
+ Misses 127 123 -4 ☔ View full report in Codecov by Sentry. |
This is intended to be an API-compatible refactor to make future extensibility and configuration of PackageCompiler.jl far simpler. The core idea is to implement a configuration process, and corresponding output datatype to be consumed by the build process. This conceptually splits the process of building sysimg/app/libs, from the high-level logic determining names, build tools, flags, etc. The benefit of this is that it immediately commonizes code that was duplicated amongst the three of: `create_sysimage`, `create_library`, and `create_app`. It will also make it far simpler to allow for configuration and propagation of flags like `ldflags` and `cflags` which are currently not easily exposed in the build process. This is a rough sketch of the idea, and so far the API seems to be preserved acceptably. Feedback and design input would be much appreciated. I suspect the `Conf` type may need some indication of `mode` since some terms are overloaded and may not make sense to define in all contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to be an API-compatible refactor to
make future extensibility and configuration of
PackageCompiler.jl far simpler. The core idea is
to implement a configuration process, and corresponding
output datatype to be consumed by the build process.
This conceptually splits the process of building sysimg/app/libs,
from the high-level logic determining names, build tools, flags,
etc. The benefit of this is that it immediately commonizes
code that was duplicated amongst the three of:
create_sysimage,create_library, andcreate_app. It will alsomake it far simpler to allow for configuration and propagation of flags
like
ldflagsandcflagswhich are currently noteasily exposed in the build process.
This is a rough sketch of the idea, and so far the API seems
to be preserved acceptably. Feedback and design
input would be much appreciated. I suspect the
Conftype may need some indication of
modesincesome terms are overloaded and may not make sense to
define in all contexts.