Allow the user to pass arbitrary C flags (on all platforms) #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Replaces #652 to no longer require a keyword argument. |
julie-is-late
force-pushed
the
c_defines_2
branch
2 times, most recently
from
dce0653
to
80ebaa2
Compare
Since PC.jl now exposes `c_driver_program` which allows the users to specify their own C wrapper program, it would be nice to be able to pass in more variables which might be best defined at build time. Currently this functionality is effectively limited to Linux as specifying $JULIA_CC will prevent PC.jl from inferring gcc.exe from the relative mingw installation.
julie-is-late
force-pushed
the
c_defines_2
branch
from
80ebaa2
to
3bd3fa1
Compare
|
Apologies for the commit spam. Sleepy brain forgot to activate the project before running the tests and was very confused about why it was failing remotely. |
Codecov Report
@@ Coverage Diff @@
## master #665 +/- ##
==========================================
+ Coverage 94.14% 95.08% +0.94%
==========================================
Files 2 2
Lines 461 468 +7
==========================================
+ Hits 434 445 +11
+ Misses 27 23 -4
Continue to review full report at Codecov.
|
julie-is-late
changed the title
|
That’s a much better way to organize it in general, so having this covered in that would be fantastic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PC.jl now exposes
c_driver_programwhich allows the users tospecify their own C wrapper program, it would be nice to be able to pass
in more variables which might be best defined at build time.
Currently this functionality is effectively limited to Linux as
specifying $JULIA_CC will prevent PC.jl from inferring gcc.exe from
the relative mingw installation.