Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompile/import into main flags & warnings for package name conflicts #794

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

krynju
Copy link

@krynju krynju commented Mar 16, 2023

Changelog:

  1. added import_into_main flag (default true), which allows you to control whether the top level packages will be imported into Main in the sysimage
  2. added disable_precompile flag (default false), which allows you to turn off the precompile part of the build completely
  3. added skip & warnings on the precompile name conflict Precompile stage doesn't support packages with the same names and different uuids #767
  4. added skip & warnings on the import to Main name conflict Incremental sysimage build doesn't support packages with same name but different uuid #768

While this doesn't fix the #767 and #768 issues it makes them not error, which in most cases will be fine.
If not then the warning should point the user at some possible solution.
The current solutions to both of these problems are either using the flags added in this PR or modifying the precompile statements.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #794 (978106f) into master (9b6b461) will decrease coverage by 0.85%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #794      +/-   ##
==========================================
- Coverage   83.08%   82.23%   -0.85%     
==========================================
  Files           3        3              
  Lines         668      670       +2     
==========================================
- Hits          555      551       -4     
- Misses        113      119       +6     
Impacted Files Coverage Δ
src/PackageCompiler.jl 92.61% <100.00%> (-0.55%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@staticfloat
Copy link
Sponsor Member

FWIW, using import_into_main = false is sufficient for me to build this example case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants