Add import_to_main flag for Main module package name conflicts resolution
#807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
reviewed
May 11, 2023
| for pkg in packages | ||
| print(julia_code_buffer, """ | ||
| if isdefined(Main, Symbol("$pkg")) | ||
| @warn( |
There was a problem hiding this comment.
Did you check that users will see this warning?
There was a problem hiding this comment.
I saw it on a build once but let me confirm on a simple example
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #807 +/- ##
=======================================
Coverage 84.64% 84.64%
=======================================
Files 3 3
Lines 827 827
=======================================
Hits 700 700
Misses 127 127 ☔ View full report in Codecov by Sentry. |
|
@KristofferC Can we merge and tag this? I confirmed it works fine on my case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains only the
import_to_mainpart of #794Fixes #768
Changelog:
import_into_mainflag (default true), which allows you to control whether the top level packages will be imported into Main in the sysimage