Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR3] E2E tests for parallel dirops #1907

Merged
merged 10 commits into from
May 22, 2024
Merged

[PR3] E2E tests for parallel dirops #1907

merged 10 commits into from
May 22, 2024

Conversation

sethiay
Copy link
Collaborator

@sethiay sethiay commented May 13, 2024 •
edited

Description

E2E tests for parallel dirops

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - Added, Run1 This run is without gRPC enabled as the tests of gRPC are flaky. Run2

@sethiay sethiay added the execute-integration-tests Run only integration tests label May 13, 2024
@sethiay sethiay mentioned this pull request May 14, 2024
Merged
@sethiay sethiay changed the base branch from master to parallel_dirops_comp_tests May 14, 2024 14:17
@sethiay sethiay removed the execute-integration-tests Run only integration tests label May 14, 2024
@sethiay sethiay marked this pull request as ready for review May 14, 2024 14:23
@sethiay sethiay requested review from ashmeenkaur and a team as code owners May 14, 2024 14:23
@sethiay sethiay requested review from raj-prince and removed request for a team May 14, 2024 14:23
@sethiay sethiay force-pushed the parallel_dirops_e2e_tests branch from 460163b to cc92deb Compare May 15, 2024 07:47
@sethiay sethiay requested a review from Tulsishah May 16, 2024 08:59
ashmeenkaur
ashmeenkaur reviewed May 16, 2024
View reviewed changes
tools/integration_tests/operations/parallel_dirops_test.go Outdated Show resolved Hide resolved
tools/integration_tests/operations/parallel_dirops_test.go Outdated Show resolved Hide resolved
tools/integration_tests/operations/parallel_dirops_test.go Show resolved Hide resolved
tools/integration_tests/operations/parallel_dirops_test.go Show resolved Hide resolved
tools/integration_tests/operations/parallel_dirops_test.go Show resolved Hide resolved
tools/integration_tests/operations/parallel_dirops_test.go Outdated Show resolved Hide resolved
tools/integration_tests/operations/parallel_dirops_test.go Outdated Show resolved Hide resolved
tools/integration_tests/operations/parallel_dirops_test.go Outdated Show resolved Hide resolved
tools/integration_tests/operations/parallel_dirops_test.go Outdated Show resolved Hide resolved
@sethiay sethiay added the execute-integration-tests Run only integration tests label May 16, 2024
@sethiay sethiay changed the base branch from parallel_dirops_comp_tests to master May 16, 2024 11:03
@sethiay sethiay force-pushed the parallel_dirops_e2e_tests branch from 18f4ecd to e909bab Compare May 16, 2024 11:06
ashmeenkaur
ashmeenkaur previously approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@ashmeenkaur ashmeenkaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for integration test changes

@sethiay sethiay force-pushed the parallel_dirops_e2e_tests branch from 95fbfa3 to 4ada573 Compare May 17, 2024 13:25
@codecov Codecov
Copy link

codecov bot commented May 17, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.94%. Comparing base (820d793) to head (a4c3ffa).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1907      +/-   ##
==========================================
- Coverage   61.30%   60.94%   -0.37%     
==========================================
  Files         129      130       +1     
  Lines       12339    12424      +85     
==========================================
+ Hits         7565     7572       +7     
- Misses       4434     4512      +78     
  Partials      340      340
Flag Coverage Δ
unittests 60.94% <ø> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethiay sethiay force-pushed the parallel_dirops_e2e_tests branch from 4ada573 to 8d3c054 Compare May 19, 2024 18:17
@sethiay sethiay removed the execute-integration-tests Run only integration tests label May 20, 2024
@sethiay sethiay force-pushed the parallel_dirops_e2e_tests branch from 8d3c054 to 404b8f1 Compare May 20, 2024 10:18
raj-prince
raj-prince reviewed May 21, 2024
View reviewed changes
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of nits.

@sethiay sethiay requested a review from raj-prince May 22, 2024 11:00
@sethiay sethiay merged commit 86573a4 into master May 22, 2024
12 of 13 checks passed
@BrewTestBot BrewTestBot mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raj-prince raj-prince raj-prince approved these changes

@ashmeenkaur ashmeenkaur ashmeenkaur left review comments

@Tulsishah Tulsishah Awaiting requested review from Tulsishah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sethiay @raj-prince @Tulsishah @ashmeenkaur