[PR1] allow parallel lookups #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethiay
added
execute-perf-test
sethiay
force-pushed
the
fix_inode_lock
branch
2 times, most recently
from
135b862
to
cad3614
Compare
sethiay
force-pushed
the
fix_inode_lock
branch
2 times, most recently
from
21f3b41
to
91d449f
Compare
sethiay
changed the title
sethiay
changed the title
raj-prince
previously approved these changes
May 16, 2024
sethiay
removed
execute-perf-test
sethiay
force-pushed
the
fix_inode_lock
branch
2 times, most recently
from
fcfeec1
to
9a208dd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1866 +/- ##
==========================================
- Coverage 61.44% 61.40% -0.04%
==========================================
Files 129 129
Lines 12298 12311 +13
==========================================
+ Hits 7556 7560 +4
- Misses 4403 4410 +7
- Partials 339 341 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
charith87
approved these changes
May 20, 2024
raj-prince
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow parallel lookups by
(a) passing FUSE_PARALLEL_DIROPS option which allows parallel dirops (readdir and lookup calls) from FUSE driver. In my experiments i noticed that with this flag, readdir becomes parallel for same directory and lookup becomes parallel for files under same mount. Also, the even without this option, the lookup calls are parallel on repeat lookups of same files. GCSFuse takes locks on dir inode during readdir operations hence with this option. for user only the lookups are parallelized.
(b) take readonly lock on dir inode instead of exclusive lock while doing lookup.
Link to the issue in case of a bug fix.
NA
Testing details