Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR2] Composite tests for Parallel dirops test. #1906

Merged
merged 5 commits into from
May 21, 2024

Conversation

sethiay
Copy link
Collaborator

@sethiay sethiay commented May 13, 2024

Description

Composite tests for Parallel dirops test.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - Added
  3. Integration tests - Run1

@sethiay sethiay added the execute-integration-tests Run only integration tests label May 13, 2024
@sethiay sethiay force-pushed the parallel_dirops_comp_tests branch 2 times, most recently from 7c5685c to 5838a45 Compare May 14, 2024 06:40
@sethiay sethiay changed the base branch from master to fix_inode_lock May 15, 2024 08:20
@sethiay sethiay marked this pull request as ready for review May 15, 2024 08:20
@sethiay sethiay requested a review from a team as a code owner May 15, 2024 08:20
@sethiay sethiay requested review from raj-prince and charith87 and removed request for a team May 15, 2024 08:20
@sethiay sethiay removed the execute-integration-tests Run only integration tests label May 15, 2024
@sethiay sethiay force-pushed the parallel_dirops_comp_tests branch from d0cf3a2 to debad0d Compare May 16, 2024 11:05
@sethiay sethiay force-pushed the parallel_dirops_comp_tests branch from debad0d to 30f8d09 Compare May 17, 2024 13:24
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.40%. Comparing base (9d7ba80) to head (4b8886f).

Additional details and impacted files
@@               Coverage Diff               @@
##           fix_inode_lock    #1906   +/-   ##
===============================================
  Coverage           61.40%   61.40%           
===============================================
  Files                 129      129           
  Lines               12311    12311           
===============================================
  Hits                 7560     7560           
- Misses               4410     4411    +1     
+ Partials              341      340    -1     
Flag Coverage Δ
unittests 61.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethiay sethiay force-pushed the parallel_dirops_comp_tests branch from 30f8d09 to 0d6e8af Compare May 19, 2024 18:14
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a could of minor comments.

@sethiay sethiay requested a review from raj-prince May 20, 2024 09:01
raj-prince
raj-prince previously approved these changes May 20, 2024
@sethiay sethiay changed the base branch from fix_inode_lock to master May 20, 2024 10:12
@sethiay sethiay dismissed raj-prince’s stale review May 20, 2024 10:12

The base branch was changed.

@raj-prince raj-prince self-requested a review May 20, 2024 17:29
@sethiay sethiay merged commit 6ccf422 into master May 21, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants