Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

need to remove call to command rebuild_index in tasks.py #11921

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

need to remove call to command rebuild_index in tasks.py #11921

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6618907
Update requirements.txt
cesarbenjamindotnet Feb 1, 2024
01fee30
Update requirements.txt
cesarbenjamindotnet Feb 1, 2024
e78f141
need to remove call to command rebuild_index in tasks.py
cesarbenjamindotnet Feb 2, 2024
aad0cd4
Merge remote-tracking branch 'origin/master'
cesarbenjamindotnet Feb 2, 2024
080134a
need to remove call to command rebuild_index in tasks.py
cesarbenjamindotnet Feb 2, 2024
e5baadb
Merge branch 'GeoNode:master' into master
cesarbenjamindotnet Feb 3, 2024
b8c2beb
Merge branch 'GeoNode:master' into master
cesarbenjamindotnet Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@ install_requires =
pinax-notifications @ git+https://github.com/GeoNode/pinax-notifications.git@django_upgrade#egg=pinax-notifications

# GeoNode org maintained apps.
django-geonode-mapstore-client>=4.0.5,<5.0.0
# django-geonode-mapstore-client==4.0.5
django-geonode-mapstore-client @ git+https://github.com/GeoNode/geonode-mapstore-client.git@master#egg=django_geonode_mapstore_client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please @cesar-benjamin do not use git versions inside setup.cfg since it breask existing geonode-project (which use their own requirements.txt in turn).
We can consider to adopt your approach, but this must be evaluated in the context of the projects. Maybe in a feature version...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i do that because for the geonode-project install method, it install geonode as pip package, so, as python packages dependencies uses setup.cfg and not requirements.txt because the usage of setuptools, so, i have to make chages on setup.cfg to can continue the development and tests, etc.

On the other hand i can understand the thing about breaks, i guess can be used the releases approach, using a release tag for get a freeze stable release, and because geonode is moving now, geonode-project need to move along with.

geonode-importer>=1.0.2
django-avatar==8.0.0
geonode-oauth-toolkit==2.2.2
Expand Down
7 changes: 0 additions & 7 deletions tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,13 +325,6 @@ def migrations(ctx):
f"python manage.py migrate --noinput --settings={_localsettings()} --database=datastore",
pty=True,
)
try:
ctx.run(
f"python manage.py rebuild_index --noinput --settings={_localsettings()}",
pty=True,
)
except Exception:
pass


@task
Expand Down