Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to remove call to command rebuild_index in tasks.py #11921

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

cesarbenjamindotnet
Copy link

when tasks.py is called, after the execution of manage.py in function migrations() there is a try block that use command rebuild_index, this returns the message 'Type "manage.py help' for usage.", i found that this is a haystack command, but haystack was removed after the add of django 4.2 support

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

Copy link

cla-bot bot commented Feb 2, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @cesar-benjamin on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Merging #11921 (b8c2beb) into master (d52b27e) will increase coverage by 22.01%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #11921       +/-   ##
===========================================
+ Coverage   41.33%   63.35%   +22.01%     
===========================================
  Files         865      865               
  Lines       52291    52291               
  Branches     6575     6575               
===========================================
+ Hits        21617    33130    +11513     
+ Misses      29548    17650    -11898     
- Partials     1126     1511      +385     

@@ -112,7 +112,8 @@ install_requires =
pinax-notifications @ git+https://github.com/GeoNode/pinax-notifications.git@django_upgrade#egg=pinax-notifications

# GeoNode org maintained apps.
django-geonode-mapstore-client>=4.0.5,<5.0.0
# django-geonode-mapstore-client==4.0.5
django-geonode-mapstore-client @ git+https://github.com/GeoNode/geonode-mapstore-client.git@master#egg=django_geonode_mapstore_client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please @cesar-benjamin do not use git versions inside setup.cfg since it breask existing geonode-project (which use their own requirements.txt in turn).
We can consider to adopt your approach, but this must be evaluated in the context of the projects. Maybe in a feature version...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i do that because for the geonode-project install method, it install geonode as pip package, so, as python packages dependencies uses setup.cfg and not requirements.txt because the usage of setuptools, so, i have to make chages on setup.cfg to can continue the development and tests, etc.

On the other hand i can understand the thing about breaks, i guess can be used the releases approach, using a release tag for get a freeze stable release, and because geonode is moving now, geonode-project need to move along with.

Copy link

cla-bot bot commented Feb 3, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @cesar-benjamin on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

Copy link
Author

@cesarbenjamindotnet cesarbenjamindotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i do that because for the geonode-project install method, it install geonode as pip package, so, as python packages dependencies uses setup.cfg and not requirements.txt because the usage of setuptools, so, i have to make chages on setup.cfg to can continue the development and tests, etc.

On the other hand i can understand the thing about breaks, i guess can be used the releases approach, using a release tag for get a freeze stable release, and because geonode is moving now, geonode-project need to move along with.

Copy link

cla-bot bot commented Feb 5, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @cesar-benjamin on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need to remove call to command rebuild_index in tasks.py
2 participants