fix: Add zero and negative byte length checks to ensure #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ensure` is a publically exported function, which has some odd behaviour when given a byte length of zero or less. It raises an error when the value is zero, but happily returns a value when the byte length is negative. I've switched these two behaviours around. ``` λ> runGet (ensure (-1)) "0123" Right "0123" λ> runGet (isolate 0 getWord8) "0123" Left "too few bytes\nFrom:\tdemandInput\n\n" ``` ``` λ> runGet (ensure (-1)) "0123" Left "Failed reading: Attempted to ensure negative amount of bytes\nEmpty call stack\n" λ> runGet (ensure 0) "0123" Right "" ```
|
Ugh... When one of the functions in This started out as a four line change... |
This adds an internal variant, `ensure'`, which is used to avoid checking for `0` and `<0` more than once in a given code path.
414owen
force-pushed
the
os/protect-ensure-values
branch
from
e208da5
to
024bba7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ensureis a publically exported function, which has some odd behaviour when given a byte length of zero or less.It raises an error when the value is zero, but happily returns a value when the byte length is negative.
I've switched these two behaviours around.
Current behaviour:
New behaviour: