feat: Add lazy isolation mode #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ensure` is a publically exported function, which has some odd behaviour when given a byte length of zero or less. It raises an error when the value is zero, but happily returns a value when the byte length is negative. I've switched these two behaviours around. ``` λ> runGet (ensure (-1)) "0123" Right "0123" λ> runGet (isolate 0 getWord8) "0123" Left "too few bytes\nFrom:\tdemandInput\n\n" ``` ``` λ> runGet (ensure (-1)) "0123" Left "Failed reading: Attempted to ensure negative amount of bytes\nEmpty call stack\n" λ> runGet (ensure 0) "0123" Right "" ```
This adds an internal variant, `ensure'`, which is used to avoid checking for `0` and `<0` more than once in a given code path.
414owen
force-pushed
the
os/lazy-isolation
branch
from
18d321e
to
5f137ef
Compare
414owen
force-pushed
the
os/lazy-isolation
branch
from
5f137ef
to
2dc6b02
Compare
414owen
changed the title
414owen
force-pushed
the
os/lazy-isolation
branch
from
8fbf050
to
ac8c7be
Compare
414owen
changed the title
|
Taking this out of draft mode, because I've got it integrated with |
414owen
commented
Mar 20, 2024
|
@glguy quick ping, because you're the last committer/merger to the repo. It doesn't look like there have been any major updates to |
|
@glguy would you be able to take a look at this please? Or do you know of someone who could? |
|
@elliottt any chance of a review, or an opinion on this change? I'd really appreciate it. |
|
I'll take a week this weekend 👍 |
elliottt
reviewed
Apr 29, 2024
414owen
force-pushed
the
os/lazy-isolation
branch
2 times, most recently
from
9e3137e
to
e585e8d
Compare
414owen
force-pushed
the
os/lazy-isolation
branch
from
e585e8d
to
ec27184
Compare
glguy
reviewed
May 23, 2024
elliottt
reviewed
May 23, 2024
glguy
reviewed
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a lazy (incremental) isolation combinator.
The use case I have for it is this:
pinch, which decodes thrift messages usingcerealisolates parsing the apparently astronomically huge message hereBy introducing an incremental isolation primitive, users can make sure the data they're parsing is valid before it all hits main memory.
Implementation notes
I tried to make sure the errors were as close as possible between
isolateandisolateLazy. This is useful for fuzzing the implementation with quickcheck, as well as just good practice. This meant I had to expose more of the failure API. I could have added an internal partial runner, which exposes this information, but that seemed like it would require a lot of changes, so I opted for adding the info to the current partial runner, and added a pattern synonym so that users (shouldn't) notice a difference.These changes are stacked on #110