Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(road-comparison): add indicator for road comparison #778

Merged
merged 37 commits into from
May 7, 2024
Merged

feat(road-comparison): add indicator for road comparison #778

merged 37 commits into from
May 7, 2024

Commits on Feb 20, 2024

  1. feat(road-comparison): add indicator for road comparison

    @Gigaszi
    Gigaszi committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    1a24d7e View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. adapted metadata to reference roads instead of buildings

    @hn437
    hn437 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    ed200ba View commit details
    Browse the repository at this point in the history

  2. added feature malta fixture for road comparison tests

    @hn437
    hn437 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    6342fc6 View commit details
    Browse the repository at this point in the history

  3. added further information to datasets.yaml

    @hn437
    hn437 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    86983e2 View commit details
    Browse the repository at this point in the history

  4. adapted to use inputs instead of hardcoded bpoly and table name

    @hn437
    hn437 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    765afb8 View commit details
    Browse the repository at this point in the history

  5. added major_roads_length as fixture

    @hn437
    hn437 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    6334683 View commit details
    Browse the repository at this point in the history

  6. updated cassette to new tests

    @hn437
    hn437 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    69a4284 View commit details
    Browse the repository at this point in the history

  7. use AoI with data and topic major roads instead of buildings

    @hn437
    hn437 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    24ddc65 View commit details
    Browse the repository at this point in the history

  8. updated cassette

    @hn437
    hn437 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    9e8c7d4 View commit details
    Browse the repository at this point in the history

  9. changed sql query to get lengths instead of ratio and calculate ratio… 

    … in calculate function
    @hn437
    hn437 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    de059f4 View commit details
    Browse the repository at this point in the history

  10. changed mock paths

    @hn437
    hn437 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    5b09c9e View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. simplified geojson.dumps to be executed in function call

    @hn437
    hn437 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    8da19fd View commit details
    Browse the repository at this point in the history

  2. fixed bug in indicator import path, commented out mocks and tests whi… 

    …ch were not yet adapted
    @hn437
    hn437 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    164a412 View commit details
    Browse the repository at this point in the history

  3. changed figure creation to use color code list of values instead of s… 

    …ets to be JSON serializeable
    @hn437
    hn437 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    def7edd View commit details
    Browse the repository at this point in the history

  4. added road comparison as indicator to major-roads-length preset

    @hn437
    hn437 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    4e54d51 View commit details
    Browse the repository at this point in the history

  5. fixed bug of wrong mock used in test

    @hn437
    hn437 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    ccebc41 View commit details
    Browse the repository at this point in the history

  6. added tests

    @hn437
    hn437 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    63307ed View commit details
    Browse the repository at this point in the history

  7. fixed bug in assert statement

    @hn437
    hn437 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    7df90b0 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. feat(road-comparison): chnage figure to bar plot

    @Gigaszi
    Gigaszi committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    ea7b350 View commit details
    Browse the repository at this point in the history

  2. road-comparison: change label and result description

    @Gigaszi
    Gigaszi committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    09cd7cf View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. added ratio text over bar and OSM Hover info to figure

    @hn437
    hn437 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    21285a6 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Updated SQL Query to new Microsoft Roads tables. Added new tables to … 

    …dataset.yaml and using them in the indicator
    @hn437
    hn437 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    4cb4c4f View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. changed datasets.yaml to use table instead of view for road feature s… 

    …election
    @hn437
    hn437 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    d75471f View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. fix: add correct table names for coverages

    @Gigaszi
    Gigaszi committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    2598027 View commit details
    Browse the repository at this point in the history

  2. fix: make query run for new database

    @Gigaszi
    Gigaszi committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    4fa1b52 View commit details
    Browse the repository at this point in the history

  3. fix: make indicators run for new databsase

    @Gigaszi
    Gigaszi committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    2dd58bc View commit details
    Browse the repository at this point in the history

  4. fix(integration-test): fix old test for RoadComparison

    @Gigaszi
    Gigaszi committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    c0e9564 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. fix: exclude road-comparison from size restriction

    @Gigaszi
    Gigaszi committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    865d604 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. changed name of table to query from in datasets.yaml, so that buildin… 

    …g comparison uses global building table
    @hn437
    hn437 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    f163a48 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into road-comparison

    @hn437
    hn437 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    140b90c View commit details
    Browse the repository at this point in the history

  3. added processing date to datasets.yaml in order to add timestamp to f… 

    …igure
    @hn437
    hn437 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    7d443b9 View commit details
    Browse the repository at this point in the history

  4. added result description including lengths to figure, added lengths t… 

    …o hover Info as well. removed unused ohsome query and made use of processing date per dataset instead
    @hn437
    hn437 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    e2e3450 View commit details
    Browse the repository at this point in the history

  5. adapted integrationtest as ohsome API is no longer queried

    @hn437
    hn437 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    8a5ae51 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. small refactor and documentation additions

    @matthiasschaub
    matthiasschaub committed May 6, 2024
    Configuration menu
    Copy the full SHA
    9aaa151 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. add comments

    @matthiasschaub
    matthiasschaub committed May 7, 2024
    Configuration menu
    Copy the full SHA
    6c863e9 View commit details
    Browse the repository at this point in the history

  2. update changelog

    @matthiasschaub
    matthiasschaub committed May 7, 2024
    Configuration menu
    Copy the full SHA
    cbdc9e8 View commit details
    Browse the repository at this point in the history

  3. remove comment

    @matthiasschaub
    matthiasschaub committed May 7, 2024
    Configuration menu
    Copy the full SHA
    f7f2a91 View commit details
    Browse the repository at this point in the history