Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(road-comparison): add indicator for road comparison #778

Merged
merged 37 commits into from May 7, 2024

Conversation

Gigaszi
Copy link
Contributor

@Gigaszi Gigaszi commented Feb 20, 2024

Description

Adds an indicator which queries the length of road data in an AoI based on Microsoft Data and how much of it is covered by OSM data. Based on this ratio a quality estimation is made.

For this, the OQAPI DB is restructured, which is why with this PR also the name of the DB table for the building comparison indicator was changed

Corresponding issue

Closes #

New or changed dependencies

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

Please check all finished tasks. If some tasks do not apply to your PR, please cross their text out (by using ~...~) and remove their checkboxes.

@hn437
Copy link
Contributor

hn437 commented Mar 4, 2024

Preprocessing and Calculation Done. All tests are done and not failing.
Figure: current figure (taken from old attribute completeness indicator) was adapted to work with plotly and to be storeable as dict. However, not yet changed to other possible plot types. If another plot type than type 'pie' is used, the last test must be adapted
@Gigaszi

@hn437
Copy link
Contributor

hn437 commented Mar 11, 2024

To use this indicator in the dashboard as long as no data (including coverage) is on the server, the coverage and preprocess function are commented out and mocks written instead. Therefore, test are failing at the moment as some check the result when the indicator is queried outside of the coverage area, but atm. it is mocked to always be within he coverage. Once data is on the server, remove the two lines of mock return in the functions and comment the real function content back in. With this, the tests should not be failing anymore

@matthiasschaub matthiasschaub self-requested a review May 7, 2024 07:22
@matthiasschaub matthiasschaub marked this pull request as ready for review May 7, 2024 09:05
@matthiasschaub matthiasschaub changed the title 🚧 feat(road-comparison): add indicator for road comparison feat(road-comparison): add indicator for road comparison May 7, 2024
@matthiasschaub matthiasschaub merged commit 4918c39 into main May 7, 2024
2 checks passed
@matthiasschaub matthiasschaub deleted the road-comparison branch May 7, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants