-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some unnecessary UNREACHABLE
s
#64035
Remove some unnecessary UNREACHABLE
s
#64035
Conversation
This is an automated comment for commit f792a60 with description of existing statuses. It's updated for the latest CI running ⏳ Click here to open a full report in a separate page
Successful checks
|
@antaljanosbenjamin Guess this PR is good to go, approve? |
Sorry for the late re-review. I left one comment, apart from that it looks okay. Even that single comment is not too important (nothing wrong will happen) and probably okay either way. I will approve and let you say the final verdict. |
7a552f5
Most
UNREACHABLE()
s clutter the code. They are often used inswitch
statements to check at runtime that all possible cases are covered. This is actually checked by a compiler warning (which are handled asWerror
) at compile time already.Changelog category (leave one):