Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unnecessary UNREACHABLEs #64035

Merged
merged 11 commits into from
May 26, 2024

Conversation

rschu1ze
Copy link
Member

Most UNREACHABLE()s clutter the code. They are often used in switch statements to check at runtime that all possible cases are covered. This is actually checked by a compiler warning (which are handled as Werror) at compile time already.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 17, 2024
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented May 17, 2024

This is an automated comment for commit f792a60 with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS⏳ pending
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Mergeable CheckChecks if all other necessary checks are successful⏳ pending
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors⏳ pending
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@antaljanosbenjamin antaljanosbenjamin self-assigned this May 17, 2024
programs/keeper-client/Commands.cpp Outdated Show resolved Hide resolved
src/Access/AccessRights.cpp Show resolved Hide resolved
src/AggregateFunctions/AggregateFunctionSum.h Outdated Show resolved Hide resolved
src/Compression/CompressionCodecDoubleDelta.cpp Outdated Show resolved Hide resolved
src/Coordination/KeeperReconfiguration.cpp Outdated Show resolved Hide resolved
src/Coordination/KeeperServer.cpp Outdated Show resolved Hide resolved
src/Parsers/Lexer.cpp Show resolved Hide resolved
@rschu1ze
Copy link
Member Author

@antaljanosbenjamin Guess this PR is good to go, approve?

@antaljanosbenjamin
Copy link
Member

Sorry for the late re-review. I left one comment, apart from that it looks okay. Even that single comment is not too important (nothing wrong will happen) and probably okay either way. I will approve and let you say the final verdict.

@rschu1ze rschu1ze enabled auto-merge May 22, 2024 20:37
@rschu1ze rschu1ze disabled auto-merge May 23, 2024 06:30
@rschu1ze rschu1ze enabled auto-merge May 26, 2024 20:36
@rschu1ze rschu1ze added this pull request to the merge queue May 26, 2024
Merged via the queue into ClickHouse:master with commit 7a552f5 May 26, 2024
242 of 248 checks passed
@rschu1ze rschu1ze deleted the unreachable-unreachable branch May 26, 2024 21:08
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants