Check what would be broken if do not add all the identifiers to functions map.

[KochetovNicolai]

Changelog category (leave one):

• Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix an Cyclic aliases error for cyclic aliases of different type (expression and function). Fixes #63205

[robot-ch-test-poll1]

This is an automated comment for commit 741e0ae with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check name	Description	Status
A Sync	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	⏳ pending
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	❌ failure
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending
Mergeable Check	Checks if all other necessary checks are successful	❌ failure
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	❌ failure

Successful checks

Check name	Description	Status
Bugfix validation	Checks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
PR Check	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success

[novikd]

In general LGTM. It's better to remove the commented code, QueryAnalysisPass.cpp is already quite big.

[novikd]

Accidental change?

[novikd]

I think it's better to move this check inside of ScopeAliases and make ScopeAliases::find return QueryTreeNodePtr instead of QueryTreeNodePtr *. This line checks that the alias map is filled with correct data.

[KochetovNicolai]

I don't know how to do it properly:

• There is a place where it's possible to not find the alias:

  ClickHouse/src/Analyzer/Passes/QueryAnalysisPass.cpp

  Lines 4198 to 4204 in 51afec4

  	auto * alias_it = scope.aliases.find(identifier_lookup, ScopeAliases::FindOption::FULL_NAME);
  	//auto alias_it = scope.alias_name_to_expression_node->find(identifier_lookup.identifier.getFullName());
  	if (alias_it && (*alias_it)->getNodeType() == QueryTreeNodeType::COLUMN)
  	{
  	const auto & column_node = (*alias_it)->as<ColumnNode &>();
  	if (column_node.getColumnSource()->getNodeType() == QueryTreeNodeType::ARRAY_JOIN)
  	prefer_column_name_to_alias = true;

• We can replace alias node to resolved one later

  ClickHouse/src/Analyzer/Passes/QueryAnalysisPass.cpp

  Line 2987 in 51afec4

  alias_node = lookup_result.resolved_identifier;

So I can't return QueryTreeNodePtr because it won't be possible to update the alias map, and I can't use QueryTreeNodePtr & because it's ok to not find an alias, and I can't use std::optional<QueryTreeNodePtr &> because this is not supported.