-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deserialize untrusted binary inputs in a safer way #64024
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse-ci-1
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
May 17, 2024
This is an automated comment for commit 20a0e73 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
Algunenano
reviewed
May 17, 2024
Algunenano
approved these changes
May 17, 2024
Algunenano
added
the
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
label
May 17, 2024
Merged
via the queue into
ClickHouse:master
with commit May 19, 2024
b405f93
228 of 231 checks passed
This was referenced May 19, 2024
robot-ch-test-poll2
added a commit
that referenced
this pull request
May 19, 2024
…0ae33e0fbb6796204b3683a560c22 Cherry pick #64024 to 24.4: Deserialize untrusted binary inputs in a safer way
robot-clickhouse
added a commit
that referenced
this pull request
May 19, 2024
robot-ch-test-poll1
added a commit
that referenced
this pull request
May 19, 2024
…0ae33e0fbb6796204b3683a560c22 Cherry pick #64024 to 23.8: Deserialize untrusted binary inputs in a safer way
robot-clickhouse
added a commit
that referenced
this pull request
May 19, 2024
robot-ch-test-poll1
added a commit
that referenced
this pull request
May 19, 2024
…0ae33e0fbb6796204b3683a560c22 Cherry pick #64024 to 24.2: Deserialize untrusted binary inputs in a safer way
robot-clickhouse
added a commit
that referenced
this pull request
May 19, 2024
robot-ch-test-poll1
added a commit
that referenced
this pull request
May 19, 2024
…0ae33e0fbb6796204b3683a560c22 Cherry pick #64024 to 24.3: Deserialize untrusted binary inputs in a safer way
robot-clickhouse
added a commit
that referenced
this pull request
May 19, 2024
robot-ch-test-poll1
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
May 19, 2024
rschu1ze
added a commit
that referenced
this pull request
May 19, 2024
Backport #64024 to 24.3: Deserialize untrusted binary inputs in a safer way
rschu1ze
added a commit
that referenced
this pull request
May 19, 2024
Backport #64024 to 24.4: Deserialize untrusted binary inputs in a safer way
rschu1ze
added a commit
that referenced
this pull request
May 19, 2024
Backport #64024 to 24.2: Deserialize untrusted binary inputs in a safer way
rschu1ze
added a commit
that referenced
this pull request
May 19, 2024
Backport #64024 to 23.8: Deserialize untrusted binary inputs in a safer way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-bugfix
Pull request with bugfix, not backported by default
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getBinaryValue
returns aField
based on a data-dependent/untrusted Field type. The right handling is to reject invalid types in all builds.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Deserialize untrusted binary inputs in a safer way.