Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the structural imager makes you learn an invalid spell that causes a segfault when cast. #73749

Closed
AmeNyaa opened this issue May 13, 2024 · 3 comments · Fixed by #73800
Closed
Labels
<Crash / Freeze> Fatal bug that results in hangs or crashes. Mods: Aftershock Anything to do with the Aftershock mod (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@AmeNyaa
Copy link

AmeNyaa commented May 13, 2024

Describe the bug

When I used the structural imager on the lastest experimental version, I stumbled upon this bug. While it's not really making the game unplayable, it's filling my spell list with junk that crashes the game. I tried to edit it out with the debug menu, but it also causes a segmentation fault.
I tested it on my save as well as on a brand new save.

Attach save file

Pandora-trimmed.tar.gz

Steps to reproduce

  1. Spawn a Structural Imager
  2. Reload it with a battery
  3. Use the Imager

Expected behavior

I kinda wish it didn't do that

Screenshots

image
image
image
image
image
image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.4291 (22H2)
  • Game Version: cdda-experimental-2024-05-13-0447 81ede3c [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth],
    Aftershock [aftershock],
    Bionic Professions [package_bionic_professions],
    Magiclysm [magiclysm],
    Mind Over Matter [mindovermatter],
    Xedra Evolved [xedra_evolved],
    No Hope [no_hope],
    Mythical Martial Arts [MMA],
    Bombastic Perks [bombastic_perks],
    Stats Through Kills [stats_through_kills]
    ]

Additional context

crash.log
debug.log

@AmeNyaa AmeNyaa added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label May 13, 2024
@Brambor Brambor added <Crash / Freeze> Fatal bug that results in hangs or crashes. Mods: Magiclysm Anything to do with the Magiclysm mod labels May 13, 2024
@Amnestasia
Copy link
Contributor

Dealt with this before, forgot to make a bug report so thankfully someone else brought it up.

Its not a Magiclysm issue, its from Aftershock

Following the aforementioned steps leads to the same result.

Doing so again without Magiclysm also led to the same results, further showing it being an Aftershock issue.

/confirm

@github-actions github-actions bot added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels May 13, 2024
@Cupidatis
Copy link

Using wands from magiclysm also make this bug.

@RenechCDDA
Copy link
Member

Structural imager is in fact, Aftershock content not Magiclysm. Bit of a mistake on the tags there.

This was introduced by #73325. It should check if the spell is known/exists before trying to get it.

known_magic::get_spell is also returning a reference to a spell that might not exist. Wow, that is also scary!

@RenechCDDA RenechCDDA added Mods: Aftershock Anything to do with the Aftershock mod and removed Mods: Magiclysm Anything to do with the Magiclysm mod labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Crash / Freeze> Fatal bug that results in hangs or crashes. Mods: Aftershock Anything to do with the Aftershock mod (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants