Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rendering vehicles while on z-level >1 causes errors #73029

Closed
mischief opened this issue Apr 14, 2024 · 1 comment · Fixed by #73747
Closed

rendering vehicles while on z-level >1 causes errors #73029

mischief opened this issue Apr 14, 2024 · 1 comment · Fixed by #73747
Labels
Code: Performance Performance boosting code (CPU, memory, etc.) curses Things specific to the curses variant of the game (S2 - Confirmed) Bug that's been confirmed to exist Vehicles Vehicles, parts, mechanics & interactions Z-levels Levels below and above ground.

Comments

@mischief
Copy link
Contributor

Describe the bug

when a vehicle is nearby and the character goes up a z level, some errors are produced:

15:58:44.908 ERROR : src/vehicle_display.cpp:64 [vpart_display vehicle::get_display_of_tile(const point&, bool, bool, bool, bool) const] no display part at mount (-5, 3)

reproducing this once with an ambulance produces ~50 errors.

Attach save file

N/A

Steps to reproduce

go to a radio tower with an ambulance nearby, and go up the tower one level

or drive up a bridge.

Expected behavior

no errors.

Screenshots

lag.mp4

Versions and configuration

gentoo, xterm, with cdda-experimental-2024-04-14-2000, built with make -j32 LOCALIZE=0 DYNAMIC_LINKING=1 ASTYLE=0 LINTJSON=0 TESTS=0 HEADERPOPULARITY=1 RELEASE=1

Additional context

on my system any error like this is extremely noticable, because addr2line is invoked for a backtrace and it creates a very noticable delay in the game (~4-8 seconds), but i suppose that's fixable by turning off backtraces.

 An error has occurred!  Written below is the error report:
 -----------------------------------------------------------
 DEBUG    : no display part at mount (-2, -1)

 FUNCTION : vpart_display vehicle::get_display_of_tile(const point&, bool, bool, bool, bool) const
 FILE     : src/vehicle_display.cpp
 LINE     : 64
 VERSION  : cdda-experimental-2024-04-14-2000 27164690b2
 -----------------------------------------------------------
 See ./config/debug.log for a full stack backtrace
 Press space bar to continue the game.
 Press I (or i) to also ignore this particular message in the future.

debug.log
@mischief mischief added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Apr 14, 2024
@NetSysFire NetSysFire added Code: Performance Performance boosting code (CPU, memory, etc.) Z-levels Levels below and above ground. Vehicles Vehicles, parts, mechanics & interactions (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Apr 14, 2024
@NetSysFire NetSysFire changed the title rendering vehicles on z-level >1 causes errors rendering vehicles while on z-level >1 causes errors Apr 14, 2024
@NetSysFire
Copy link
Member

Can reproduce. So far on curses only.

@NetSysFire NetSysFire added the curses Things specific to the curses variant of the game label Apr 15, 2024
@irwiss irwiss mentioned this issue May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code: Performance Performance boosting code (CPU, memory, etc.) curses Things specific to the curses variant of the game (S2 - Confirmed) Bug that's been confirmed to exist Vehicles Vehicles, parts, mechanics & interactions Z-levels Levels below and above ground.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include vehicle roofs for map::draw_from_above irwiss/Cataclysm-DDA
2 participants
@mischief @NetSysFire