Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages for effects on other creatures is hardcoded #73746

Open
Hresvelgr401 opened this issue May 13, 2024 · 2 comments
Open

Messages for effects on other creatures is hardcoded #73746

Hresvelgr401 opened this issue May 13, 2024 · 2 comments
Labels
[C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON <Suggestion / Discussion> Talk it out before implementing

Comments

@Hresvelgr401
Copy link

Is your feature request related to a problem? Please describe.

I noticed that when a creature is downed a message is played when it attempts to stand. I tried to replicated this for a status effect I made but found that this was hardcoded rather then modifiable through .json

Solution you would like.

If this text could be modified or added to effects using JSON files it would add more options for modding

Describe alternatives you have considered.

No response

Additional context

No response

@Hresvelgr401 Hresvelgr401 added the <Suggestion / Discussion> Talk it out before implementing label May 13, 2024
@Brambor
Copy link
Contributor

Brambor commented May 13, 2024

You can try to find the message. Dehardcoding might be less work if the person doing it is given the precise location of the text. And you can make sure the message isn't crazy complicated to construct.

@Brambor Brambor added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON labels May 13, 2024
@Hresvelgr401
Copy link
Author

The message is found here https://github.com/CleverRaven/Cataclysm-DDA/blob/master/src/monster.cpp#L2261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

2 participants