Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immediate Segmentation Fault Crash when pressing construction button (consistently reoccurring) #73718

Closed
Nameless-Survivor opened this issue May 12, 2024 · 3 comments · Fixed by #73785
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Crash / Freeze> Fatal bug that results in hangs or crashes. (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@Nameless-Survivor
Copy link

Describe the bug

The game crashes via segmentation fault every time I press the construction button.

Attach save file

Yarmouth-trimmed.tar.gz
crash.log

Steps to reproduce

Press construction button ( * ).

Expected behavior

Construction menu opens.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.22631.3447 (23H2)
  • Game Version: 59351db [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth],
    Stats Through Skills [StatsThroughSkills]
    ]

Additional context

Not sure why it has begun crashing. I managed to use the construction menu to set up my base without issues (I did have a couple random segfault crashes, but they may have been unrelated and did not reoccur).

The current state of permanent instant-crash on pressing the construction button began when I tried to install the drill press I just brought back.

Crash occurs regardless of location on map. Does not occur on save files on other worlds.

@Nameless-Survivor Nameless-Survivor added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label May 12, 2024
@Procyonae
Copy link
Contributor

/confirm I don't even get a crash log for whatever reason

@NetSysFire NetSysFire added (S2 - Confirmed) Bug that's been confirmed to exist <Crash / Freeze> Fatal bug that results in hangs or crashes. and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels May 12, 2024
@Procyonae
Copy link
Contributor

Exception occurs on L955 Unhandled exception at 0x00007FF6E519DD33 in cataclysm-tiles.exe: 0xC0000005: Access violation reading location 0x0000000000000000.

if( select < 0 || static_cast<size_t>( select ) >= constructs.size()
|| con_preview_group != constructs[select] ) {
con_preview_group = ( select >= 0 || static_cast<size_t>( select ) < constructs.size() )
? constructs[select] : construction_group_str_id::NULL_ID();

Caused by #73455

Seems like it can do constructs[select] where select is negative? At a guess it should be

 if( select < 0 || static_cast<size_t>( select ) >= constructs.size() 
     || con_preview_group != constructs[select] ) { 
-     con_preview_group = ( select >= 0 || static_cast<size_t>( select ) < constructs.size() ) 
+     con_preview_group = ( select >= 0 && static_cast<size_t>( select ) < constructs.size() ) 
                         ? constructs[select] : construction_group_str_id::NULL_ID(); 

@NetSysFire NetSysFire added Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [C++] Changes (can be) made in C++. Previously named `Code` labels May 12, 2024
@Bulaleks
Copy link

Same issue. Fresh World with copied settings doesn't produce crash.
North Belle Vernon-trimmed.tar.gz
crash.log
debug.log

  • OS: Windows
    • OS Version: 10.0.19045.4291 (22H2)
  • Game Version: 81ede3c [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth],
    SpeedyDex [speedydex],
    Stats Through Kills [stats_through_kills],
    Stats Through Skills [StatsThroughSkills],
    Aftershock [aftershock],
    Bombastic Perks [bombastic_perks],
    Bionic Slots [cbm_slots]
    ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Crash / Freeze> Fatal bug that results in hangs or crashes. (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants