Adding ThM (modified throttle send to engine) to EFIS log #27077
+21
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
loki077
commented
May 16, 2024
loki077
commented
- ThM added to help understand the engine logs better
- Updated the field names to keep the total length 64-characters long.
- ThM added to help understand the engine logs better - Updated the field names to keep the total length 64-characters long.
peterbarker
requested changes
May 17, 2024
| @@ -205,6 +205,7 @@ void AP_EFI_Serial_Hirth::send_request() | |||
| bool AP_EFI_Serial_Hirth::send_target_values(uint16_t thr) | |||
| { | |||
| uint8_t computed_checksum = 0; | |||
| throttle = 0; | |||
There was a problem hiding this comment.
This is a little too generic a name for a member variable IMO.
Perhaps
Suggested change
| throttle = 0; | |
| throttle_to_hirth = 0; |
Comment on lines
+373
to
+379
| // @Field: ES1: Status of EGT1 excess temperature error | ||
| // @Field: ES2: Status of EGT2 excess temperature error | ||
| // @Field: CS1: Status of CHT1 excess temperature error | ||
| // @Field: CS2: Status of CHT2 excess temperature error | ||
| // @Field: ETS: Status of Engine temperature sensor | ||
| // @Field: ATS: Status of Air temperature sensor | ||
| // @Field: APS: Status of Air pressure sensor |
There was a problem hiding this comment.
Many of these are booleans. You could save columns and logging bandwidth by logging them into a bitmask.
Many analysis tools do have reasonable support for bitmasks now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.