Parameter: CRASH_DETECT Param doc update to add 1 in value set #27070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loki077
force-pushed
the
pr_crash_detec_doc_fix
branch
from
20426d6
to
39af26d
Compare
peterbarker
force-pushed
the
pr_crash_detec_doc_fix
branch
from
39af26d
to
169533c
Compare
peterbarker
approved these changes
May 16, 2024
magicrub
requested changes
May 16, 2024
Fair call. In fact, that is the correct fix, as both MAVProxy and MissionPlanner ignore the @values field if @bitmask is present! I have created #27082 to enforce the same rule as we have had in libraries for years - you can only have one of @values or @bitmask @loki077 you could simply remove the @values as part of this PR - or we could merge mine which will close this one as Merged. |
loki077
force-pushed
the
pr_crash_detec_doc_fix
branch
from
169533c
to
d89d21a
Compare
As this was causing a CI check fail, which we made locally to compare param range from metadata. We only need bitmask or values and not both, in this case we are removing values.
loki077
force-pushed
the
pr_crash_detec_doc_fix
branch
from
d89d21a
to
a96d417
Compare
|
@peterbarker I have forced pushed the change. You can also make it a part of your PR. |
I've merged that other PR now - so closing this one. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this was causing a CI check we made locally to compare param values to param_metadata generated xml file.