-
Notifications
You must be signed in to change notification settings - Fork 16.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase lag pre-arm check #27068
base: master
Are you sure you want to change the base?
Phase lag pre-arm check #27068
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe go to 1.0 so it passes with quad multi-src with 1:4 ratio?
669a513
to
0db55a2
Compare
After discussion with @lthall we decided f/sqrt(nsources) was a suitable compromise in terms of pre-arm check. Adjusting attenuation unfortunately is unlikely to make enough of a difference. |
15aaabf
to
69451bd
Compare
I'm surprised about this. At zero attenuation there should be no phase lag. I wrote a little test to check this out and got this: |
c941739
to
984edff
Compare
Made a separate PR for discussion so as to not hold up #26674
@tridge your original suggestion was
bw > 0.75*freq/nsources
, I assume that was a typo because that will break the configuration of all 14 of my copters that are using this feature very successfully (and for which this feature was originally written) 😄 I have changed that tobw * 0.75 > freq/nsources
which at least does not break many existing configurations but it does not work on octacopters. It is impossible to get the octacopter test to pass with this setting which was my original concern with having any check like this - it simply does not filter enough noise. My suggestion therefore is either to make this a warning or simply clamp the check at f/4. Either way much discussion and testing required!