Immobilized While Casting #1839
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ming any action when casting finished.
…into AbilityMoveSpeed
zunath
reviewed
May 14, 2024
| @@ -273,6 +273,11 @@ void CompleteActivation(string id, float abilityRecastDelay) | |||
| CheckForActivationInterruption(activationId, position); | |||
| SetLocalInt(activator, activationId, (int)ActivationStatus.Started); | |||
|
|
|||
| if (GetIsPC(activator) && !Space.IsPlayerInSpaceMode(activator)) | |||
| { | |||
| ApplyEffectToObject(DurationType.Temporary, EffectCutsceneImmobilize(), activator, 1.5f); | |||
There was a problem hiding this comment.
Any real significance to 1.5 seconds? Do you want to account for heavy armor here? I.E longer immobilize time compared to light?
There was a problem hiding this comment.
For abilities with cast times 1.5 seconds is usually the lowest they go (pretty sure that's what throw lightsaber is at). 1.5 seconds should be enough time for, if someone is trying to kite an enemy who is right behind them, for them to both be stopped and for the enemy chasing them to begin a flurry of attacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a player activates an ability, they are immobilized for 1.5 seconds. No other effects are applied during this. The old requirement that players not have any action queued up when an ability finished was removed, as this was janky (WASD did not cause a failure, only click moving).
Most abilities have a cast time beyond 1.5 seconds, notably tame and resurrect abilities. Players being able to move during this time however is fine. The point is to reduce/eliminate the Benny Hill combat system we have now so that we can begin balancing around a system that doesn't have people running in circles.
The immobilize only applies to PC's who are not in space mode, as this isn't an issue in space.