Space Update #1819

Valo56 · 2024-02-02T09:04:30Z

For now all I've done is added chat commands for DM's to see ship stats and repair targeted ships.

More to come in time.

…ips.

…r PC's and NPC's. Added a skill level check to the shipstats command.

…service for config modules. Also updated combat lasers and ion cannons. Player ship stats have been updated in line with planned NPC and weapon changes.

…eral perk.

…overhauled weapons, added a new feat, and added a new module category - configuration modules, to provide base stats to ships.

…vised the function of existing modules.

SWLOR.Game.Server/Feature/ChatCommandDefinition/DMChatCommand.cs

SWLOR.Game.Server/Feature/GuiDefinition/ViewModel/ShipManagementViewModel.cs

…riptions. Damage increases across the board as during testing fights were taking too long.

zunath · 2024-04-30T23:39:26Z

SWLOR.Game.Server/Feature/ChatCommandDefinition/DMChatCommand.cs

+                .RequiresTarget()
+                .Action((user, target, location, args) =>
+                {
+                    if (GetIsDM(target) != true && GetIsDMPossessed(target) != true)


Small stylistic thing, but would prefer this to be either:

!GetIsDM(target) && !GetIsDMPossessed(target)

or

GetIsDM(target) == false && GetIsDMPossessed(target) == false

The first one is more preferred over the second, but != true is weird :D

zunath · 2024-04-30T23:42:24Z

SWLOR.Game.Server/Feature/GuiDefinition/ShipManagementDefinition.cs

+                    col.AddRow(row =>
+                    {
+                        row.AddButtonImage()
+                         .BindImageResref(model => model.Configuration1Resref)


Let's fix the tab formatting on this stuff. One tab for each dot method, new line in between elements.

zunath · 2024-04-30T23:50:08Z

SWLOR.Game.Server/Feature/LootTableDefinition/SpaceLootTableDefinition.cs

-            _builder.Create("SPACE_SYBIL")
-                .AddItem("elec_ruined", 20)
-                .AddItem("ref_tilarium", 3);
+            _builder.Create("SPACE_BASIC_T1")


Please review these loot tables for anything that needs to be marked as a rare item. Right now none of them are, so Treasure Hunter won't work.

zunath · 2024-04-30T23:51:09Z

SWLOR.Game.Server/Feature/PerkDefinition/GeneralPerkDefinition.cs

@@ -1,9 +1,11 @@
 using System.Collections.Generic;
 using SWLOR.Game.Server.Core.NWScript.Enum;
 using SWLOR.Game.Server.Entity;
+using SWLOR.Game.Server.Enumeration;


These changes aren't necessary. Please remove.

zunath · 2024-04-30T23:52:48Z

SWLOR.Game.Server/Feature/RecipeDefinition/EngineeringRecipeDefinition/ModuleRecipes.cs

+
+            // Mirrored Plating 1
+            _builder.Create(RecipeType.ThermalArmor1, SkillType.Engineering)
+				.Category(RecipeCategoryType.ShipModule)


Bunch of weird formatting with the tabs here.

I think I've fixed the tabs now, please let me know if not, but none of this weirdness was showing for me in VS in the first place.

zunath · 2024-04-30T23:53:22Z

SWLOR.Game.Server/Feature/RecipeDefinition/EngineeringRecipeDefinition/ModuleRecipes.cs

@@ -494,6 +602,60 @@ private void Tier3()
 				.Component("ref_idailia", 5)
 				.Component("elec_good", 3);

+			// Hypermatter Injector III


I need these recipes added to the Bible too.

I'll get a full list of updated stats and recipes your way soon. If you'd like it sooner than later I can get on that otherwise I was planning on waiting until wider testing was underway and further changes are unlikely.

zunath · 2024-04-30T23:54:49Z

SWLOR.Game.Server/Feature/ShipDefinition/NPCShipDefinition.cs

-            _builder.Create("NPC_Sybil")
-                .ItemResref("npc_sybil")
-                .Name("NPC - Sybil")
-                .Appearance(AppearanceType.SWLORShipNeutralDropship)


The appearance on all of these ships is missing. Can you double check on this? Are they actually showing the right models?

The right models display, the appearance in the code seems to be unnecessary for npc's, it's just pc's that need it.

zunath · 2024-05-01T00:02:46Z

SWLOR.Game.Server/Feature/ShipModuleDefinition/MiningLaserModuleDefinition.cs

@@ -55,10 +55,16 @@ private void MiningLaser(string itemTag, string name, string shortName, int requ
                        return "This mining laser is not powerful enough to harvest that asteroid.";
                    }

+                    if (GetLocalBool(target, "BEING_MINED") == true)


Drop the == true, not needed.

Please put "BEING_MINED" into a constant.

zunath · 2024-05-01T00:06:08Z

SWLOR.Game.Server/Feature/ShipModuleDefinition/MiningLaserModuleDefinition.cs

@@ -132,6 +138,7 @@ private void MiningLaser(string itemTag, string name, string shortName, int requ
                            var xp = Skill.GetDeltaXP(delta);

                            Skill.GiveSkillXP(activator, SkillType.Piloting, xp);
+                            SetLocalBool(target, "BEING_MINED", false);


I'd put this variable outside the PC check. If, somehow, a non-PC uses a mining laser the rock will be locked forever.

zunath · 2024-05-01T00:06:46Z

SWLOR.Game.Server/Feature/ShipModuleDefinition/MissileLauncherModuleDefinition.cs

+                .Recast(12f)
+                .ValidationAction((activator, activatorShipStatus, target, targetShipStatus, moduleBonus) =>
+                {
+                    var item = GetItemPossessedBy(activator, "ship_missile");


Another situation where I'd set "ship_missile" to a constant so you are limiting the use of magic strings.

zunath · 2024-05-01T00:08:46Z

SWLOR.Game.Server/Feature/ShipModuleDefinition/ShipArmorModuleDefinition.cs

+                .EquippedAction((creature, shipStatus, moduleBonus) =>
+                {
+                    shipStatus.ThermalDefense += armorBoost + moduleBonus;
+                    shipStatus.EMDefense+= armorBoost + moduleBonus;


Really minor but can you put a space before the plus sign here?

zunath · 2024-05-01T00:10:40Z

SWLOR.Game.Server/Feature/ShipModuleDefinition/ShipConfigurationModuleDefinition.cs

+                .ShortName(name)
+                .Texture(texture)
+                .Description($"Provides several base stats to a ship to allow it to fulfill a role and operate at full capacity: \n" +
+                $"Armor: +{armor} + Module Bonus * 4 \n" +


Since this is being displayed to players, I'd recommend using "x4" instead of "* 4" simply because non-programmers might not understand what that notation means.

zunath · 2024-05-01T00:16:53Z

SWLOR.Game.Server/Service/SpaceService/ShipBuilder.cs

+        /// Sets the number of ship configuration nodes on this ship.
+        /// By default ships should have 1 configuration node.
+        /// </summary>
+        /// <param name="shipConfigurationNodes">The number of low power nodes to set.</param>


Description for this param is wrong

zunath · 2024-05-01T00:19:28Z

SWLOR.Game.Server/Feature/ShipModuleDefinition/CapitalWeaponsModuleDefinition.cs

+                    var defense = Stat.GetDefense(target, CombatDamageType.Thermal, AbilityType.Vitality, defenseBonus);
+                    if (attackRoll < 7)
+                    {
+                        attackType = "laser";


Strings are very error prone and difficult to maintain. Please set up an enumeration - you can make it private within this class. I.E:

private enum AttackType
{
Invalid = 0,
Laser = 1,
...etc
}

zunath · 2024-05-01T00:21:10Z

SWLOR.Game.Server/Feature/ShipModuleDefinition/CapitalWeaponsModuleDefinition.cs

+                    var sound = EffectVisualEffect(VisualEffect.Vfx_Ship_Blast);
+                    var missile = EffectVisualEffect(VisualEffect.Mirv_StarWars_Bolt2);
+
+                    if (attackType == "laser")


This method is getting very long. I would recommend splitting it up a bit. Perhaps a method for laser attacks, another for ion attacks, etc. There needs to be some organization here because it's going to be hard to maintain.

zunath · 2024-05-01T00:21:42Z

SWLOR.Game.Server/Feature/ShipModuleDefinition/CapitalWeaponsModuleDefinition.cs

+                                ApplyEffectToObject(DurationType.Instant, sound, target);
+                                ApplyEffectToObject(DurationType.Instant, missile, target);
+
+                                DelayCommand(0.3f, () =>


What's the purpose of the delay?

The delay is the same as for combat lasers I believe (on phone atm hard to double check). Just has the damage and other effects occur after allowing time for the vfx to conclude.

… ship modules.

…hip stats.

…eness of industrial modules for mining, reduced effectiveness of modulebonuses on lasers for mining.

…le as Dathomir, which makes sense to me based on what the Red Hand are). Music for remaining space areas adjusted.

…e interiors to address pathing issues.

…ig modules.

…capital ship only, immobilizing and leaving vulnerable the mining vessel using it. Also adjusted Proton Bomb range based on feedback.

…es of bomber configurations. Fixed ship armor recipes. Increased missile drop rates. Reduced Intuitive Piloting to require 0 Piloting in response to feedback. Balance adjustments mostly involved buffs to turbolaser damage and increase to hull/SP extending modules and repairers.

…their target is dead. Balance update to corvettes, granting them additional cap.

…ips.

… NUI.

zunath · 2024-05-25T23:09:09Z

SWLOR.Game.Server/Feature/ShipModuleDefinition/BulwarkShieldGeneratorModuleDefinition.cs

+                .CanTargetSelf()
+                .ActivatedAction((activator, activatorShipStatus, target, targetShipStatus, moduleBonus) =>
+                {
+                    var industrialBonus = Space.GetShipStatus(activator).Industrial;


This has the potential to cause a null reference exception. Space.GetShipStatus can return a null in certain cases. I believe you need to add a null check here (and anywhere else) to bail out early if you don't have a valid ShipStatus object.

Actually, looking at it closer you shouldn't need to call this at all. You already have activatorShipStatus available to you. Just use that and you don't need the null check.

Adjusted this.

…o SpaceUpdate

zunath · 2024-06-01T15:05:00Z

SWLOR.Game.Server/Feature/ShipModuleDefinition/ShipArmorModuleDefinition.cs

+        {
+            _builder.Create(itemTag)
+                .Name(name)
+                .ShortName(name)


This should be shortName

zunath · 2024-06-01T15:05:06Z

SWLOR.Game.Server/Feature/ShipModuleDefinition/ShipArmorModuleDefinition.cs

+        {
+            _builder.Create(itemTag)
+                .Name(name)
+                .ShortName(name)


This should be shortName

zunath · 2024-06-01T15:05:10Z

SWLOR.Game.Server/Feature/ShipModuleDefinition/ShipArmorModuleDefinition.cs

+        {
+            _builder.Create(itemTag)
+                .Name(name)
+                .ShortName(name)


This should be shortName

Valo56 and others added 9 commits February 2, 2024 01:03

Added chat commands for DM's to see ship stats and repair targeted sh…

97c273c

…ips.

Merge branch 'master' into SpaceUpdate

5b1a455

Global Cooldown of 2 seconds added to all space module activations fo…

1599ff2

…r PC's and NPC's. Added a skill level check to the shipstats command.

Removed unused, unintended addition.

a233b16

Added ship config modules, updated NUI, added necessary code to space…

b902dc7

…service for config modules. Also updated combat lasers and ion cannons. Player ship stats have been updated in line with planned NPC and weapon changes.

Changed Zen Marksmanship to have no skill requirement. Changed to Gen…

909a95f

…eral perk.

Reverted change to Zen Marksmanship. Added in Intuitive Piloting perk.

4d78c93

Space Overhaul part 1. New NPC's, global cooldown, new ship modules, …

87d29ed

…overhauled weapons, added a new feat, and added a new module category - configuration modules, to provide base stats to ships.

Implemented a whole new roster of NPC's, new modules, recipes, and re…

26a36a8

…vised the function of existing modules.

zunath reviewed Apr 29, 2024

View reviewed changes

SWLOR.Game.Server/Feature/ChatCommandDefinition/DMChatCommand.cs Show resolved Hide resolved

zunath reviewed Apr 29, 2024

View reviewed changes

SWLOR.Game.Server/Feature/GuiDefinition/ViewModel/ShipManagementViewModel.cs Show resolved Hide resolved

zunath reviewed Apr 29, 2024

View reviewed changes

SWLOR.Game.Server/Feature/GuiDefinition/ViewModel/ShipManagementViewModel.cs Show resolved Hide resolved

Fixed hypermatter injectors so they can be used on self. Updated desc…

0db3210

…riptions. Damage increases across the board as during testing fights were taking too long.

zunath reviewed Apr 30, 2024

View reviewed changes

Merge branch 'master' into SpaceUpdate

3bd91ff

zunath reviewed Apr 30, 2024

View reviewed changes

zunath reviewed May 1, 2024

View reviewed changes

Valo56 and others added 22 commits May 6, 2024 06:25

Renamed all new modules to align with existing naming conventions for…

13ab890

… ship modules.

Renamed all new modules to align with existing naming conventions for…

caea292

… ship modules.

Fixed a placeable in Viscaran space. More balance adjustments to caps…

c6a158a

…hip stats.

NPC capships have more diverse weapons now.

994a9ac

Nerfed loot tables. Reduced asteroid overall yield. Improved effectiv…

bbcda5a

…eness of industrial modules for mining, reduced effectiveness of modulebonuses on lasers for mining.

Adjusted Dantooine to have updated spawns (it uses the same spawn tab…

c1e4db4

…le as Dathomir, which makes sense to me based on what the Red Hand are). Music for remaining space areas adjusted.

Changed industrial module names to logistics. More changes to corvett…

1412101

…e interiors to address pathing issues.

Fixed issue with shortName not being used for config modules.

78dd5d3

Adjusted recipes to also use Logistics instead of Industrial for conf…

a78e77b

…ig modules.

Fixes to Dantooine/Mon Cala starlane transitions.

72d38e9

Strip miners added. They function similarly to mining lasers but are …

e534812

…capital ship only, immobilizing and leaving vulnerable the mining vessel using it. Also adjusted Proton Bomb range based on feedback.

Fixed icon for Strip Miners.

7672fb8

Merge branch 'zunath:master' into SpaceUpdate

a9a363a

Merge branch 'zunath:master' into SpaceUpdate

723ddc5

Updated description of turbolasers.

3d781c1

Added checks to Storm Cannon and Turbolaser so they stop firing once …

677ce10

…their target is dead. Balance update to corvettes, granting them additional cap.

Adjustments to T5+ NPC ship loadouts for gunships, bombers, and capsh…

510b833

…ips.

Fixed issue with T5 NPC capship not having enough capacitor.

46f7f89

Fixed ion shielding modules and recipes.

0a8630c

Fixed how icon for Redundant Shield Generator displays in Ship Config…

b55f417

… NUI.

Merge branch 'master' into SpaceUpdate

3ce74c7

zunath reviewed May 25, 2024

View reviewed changes

Valo56 added 2 commits May 29, 2024 01:01

Updated BulwarkShieldGenerator to use activatorShipStatus.

a5f97c0

Merge branch 'SpaceUpdate' of https://github.com/Valo56/SWLOR_NWN int…

5dd9ce5

…o SpaceUpdate

zunath reviewed Jun 1, 2024

View reviewed changes

zunath approved these changes Jun 1, 2024

View reviewed changes

zunath merged commit b2eeb74 into zunath:master Jun 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Space Update #1819

Space Update #1819

Valo56 commented Feb 2, 2024

zunath Apr 30, 2024

zunath Apr 30, 2024

zunath Apr 30, 2024

zunath Apr 30, 2024

zunath Apr 30, 2024

Valo56 May 1, 2024

zunath Apr 30, 2024

Valo56 May 1, 2024

zunath Apr 30, 2024

Valo56 Apr 30, 2024

zunath May 1, 2024

zunath May 1, 2024

zunath May 1, 2024

zunath May 1, 2024

zunath May 1, 2024

zunath May 1, 2024

zunath May 1, 2024

zunath May 1, 2024

zunath May 1, 2024

Valo56 May 1, 2024

zunath May 25, 2024

zunath May 25, 2024

Valo56 May 29, 2024

zunath Jun 1, 2024

zunath Jun 1, 2024

zunath Jun 1, 2024

Space Update #1819

Space Update #1819

Conversation

Valo56 commented Feb 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment