Control Companion #1818
Open
Control Companion #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zunath
reviewed
Apr 13, 2024
| var associate = GetHenchman(user); | ||
| if (target == associate) | ||
| { | ||
| Enmity.ClearEnmityTables(associate); |
There was a problem hiding this comment.
This is abusable. We shouldn't be letting players clear enmity tables of their droids/beasts.
Removed the part of the code that cleared enmity tables.
Undid the change to the Enmity service, since ClearEnmityTables is no longer used by the command.
|
I've updated it to not clear enmity tables. That was in place to ensure creatures were always receptive to orders but I suppose enmity on NPC companions getting in the way of them following orders may make enmity a more important mechanic. Maybe down the line a "Calm Pet" beastmaster command could be added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This chat command will target a given NPC, unlocked door or placeable.
-If the NPC is hostile, or the target is a pleaceable, the user's henchman will attack it.
-If the target is an unlocked door, the henchman will open it.