right_sidebar: Avoid 'user' word in class name. #30111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having 'user' name is class name make chrome treat it as username field and chrome tries to autofill it. Reproducer: * Go to settings > accounts & privacy * Click manage your API key * Try to autofill your password. Along with the password being autofilled, right sidebar search is filled with your email.
See previous commit for details.
amanagr
changed the title
timabbott
reviewed
May 16, 2024
| @@ -12,7 +12,7 @@ export class UserSearch { | |||
| // details of populating the list when we change. | |||
|
|
|||
| $widget = $("#user_search_section").expectOne(); | |||
| $input = $<HTMLInputElement>("input.user-list-filter").expectOne(); | |||
| $input = $<HTMLInputElement>("input.people-list-filter").expectOne(); | |||
There was a problem hiding this comment.
What if we did buddy-list-filter? I feel like that aligns with the newer buddy_data / buddy_list names we're using.
|
Could we better address this issue with |
|
We are already using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having 'user' name is class name make chrome treat it as username field and chrome tries to autofill it.
Reproducer:
Along with the password being autofilled, right sidebar search is filled with your email.