-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api_docs: Add table of links for easy navigation in events api docs. #30105
base: main
Are you sure you want to change the base?
Conversation
1aa0e44
to
b397407
Compare
] | ||
events_table_str.extend(op_list) | ||
events_table_str.append("</div>") | ||
events_table_str.append("</div>") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it easy to write this using a Jinja2
template (i.e. the things under templates/
) instead? Generally our policy is for HTML to be done in templates unless there's a very good reason to do something different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be something we should leave to a follow-up, since this file doesn't use those as a general pattern.
.events-table { | ||
column-count: 1; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't CSS grid be able to just show as many columns as there are space for, without all these media queries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it but was having trouble getting everything in place. The items were arranged horizontally instead of vertically.
This first commit adds a table of links for easy navigation of events in API documentation.
The second commit converts the event names in API documentation to lowercase.
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: