Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typed_endpoint: creates type for gcm_payload and apns_payload in Remo… #30098

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

franciscofleury
Copy link
Collaborator

…teServerNotificationPayload

Before this commit RemoteServerNotificationPayload.gcm_payload and RemoteServerNotificationPayload.apns_payload were both Dict[str, Any]. Now a class is used to type these fields. Note that by changing from a Dict to a class gcm_payload and apns_payload properties cannot be acessed with the .get() method anymore since this is a dict-only method.

Fixes:

Screenshots and screen captures:

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

…teServerNotificationPayload

Before this commit RemoteServerNotificationPayload.gcm_payload and RemoteServerNotificationPayload.apns_payload were both Dict[str, Any]. Now a class is used to type these fields. Note that by changing from a Dict to a class gcm_payload and apns_payload properties cannot be acessed with the .get() method anymore since this is a dict-only method.
@alya
Copy link
Contributor

alya commented May 15, 2024

Thanks! Please go through our guide on submitting a pull request to learn how to present your proposed changes to Zulip, so that your work can be reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants