-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recent_view: Complete TODO to use first unmuted unread message id. #30060
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: web/src/ui_init.js
Did you find this useful? React with a 👍 or 👎 |
web/src/narrow.js
Outdated
@@ -86,7 +86,7 @@ export function changehash(newhash, trigger) { | |||
browser_history.set_hash(newhash); | |||
} | |||
|
|||
export function save_narrow(terms, trigger) { | |||
export function set_hash_to_filter_terms(terms, trigger) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe update_hash_to_match_filter
would be a better name? And then maybe we should just pass filter, trigger
as the parameters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, updated!
4f20639
to
5c6fbdb
Compare
5c6fbdb
to
d34425b
Compare
d34425b
to
b4af75e
Compare
We already had the data at initial request, so we just add some plumbing to make it available.
b4af75e
to
7d41c8c
Compare
Merged, after moving one hunk to the last commit. I don't love the implementation; I worry about those |
We already had the data at initial request, so we just add some plumbing to make it available.
Followup to #30008 (comment)