Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send test mail #7968

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat: send test mail #7968

wants to merge 15 commits into from

Conversation

doncicuto
Copy link
Contributor

Which Problems Are Solved

  • Zitadel doesn't have a way to test SMTP settings either before creating a new provider or once the SMTP provider has been created.
  • Zitadel SMTP messages can be more informative for usual errors

How the Problems Are Solved

  • A new step is added to the new/update SMTP provider wizard that allows us to test a configuration. The result is shown in a text area.
  • From the table of SMTP providers you can test your settings too.
  • The email address to send the email is by default the email address for the logged in user as suggested.
  • Some of the SMTP error messages have been changed to give more information about the possible situation. For example: could not contact with the SMTP server, check the port, firewall issues... instead of could not dial

Here's a video showing this new option in action:

test_smtp.mp4

Additional Changes

Replace this example text with a concise list of additional changes that this PR introduces, that are not directly solving the initial problem but are related.
For example:

  • The docs explicitly describe that the property XY is mandatory
  • Adds missing translations for validations.

Additional Context

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 5:53pm

@hifabienne hifabienne added the os-contribution This is a contribution from our open-source community label May 16, 2024
@doncicuto doncicuto changed the title Feat 4504 feat: send test mail May 16, 2024
proto/zitadel/settings.proto Outdated Show resolved Hide resolved
proto/zitadel/admin.proto Outdated Show resolved Hide resolved
internal/api/grpc/admin/smtp.go Outdated Show resolved Hide resolved
internal/api/grpc/admin/smtp.go Outdated Show resolved Hide resolved
@hifabienne hifabienne added the waiting For some reason, this issue will have to wait. This can be a feedback that is being waited for, a de label May 29, 2024
@doncicuto
Copy link
Contributor Author

Hi @hifabienne, I think I've solved some issues so the review can be resumed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os-contribution This is a contribution from our open-source community waiting For some reason, this issue will have to wait. This can be a feedback that is being waited for, a de
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

SMTP send test mail
3 participants