-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(console): add new step to activate SMTP provider #7956
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it @doncicuto 🚀
Just some minor change requests...
console/src/app/modules/smtp-provider/smtp-provider.component.html
Outdated
Show resolved
Hide resolved
Sure @eliobischof, thanks for your review I'll prepare the changes ASAP |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7956 +/- ##
==========================================
- Coverage 62.76% 62.75% -0.01%
==========================================
Files 1341 1341
Lines 111028 111029 +1
==========================================
- Hits 69682 69678 -4
- Misses 37423 37426 +3
- Partials 3923 3925 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@doncicuto can you have a look at the e2e tests, please?
Head branch was pushed to by a user without write access
Sorry @eliobischof I totally missed the e2e tests, my bad 😳 |
🎉 This PR is included in version 2.53.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Which Problems Are Solved
How the Problems Are Solved
activate_smtp_wizard.mp4
Additional Context