std.DynamicBitSetUnmanaged: respect padding bits #19945
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisstaloch
force-pushed
the
dyn-bitset-fixes
branch
from
03f3b0c
to
495ff99
Compare
closes ziglang#19933 This patch makes setAll() preserve padding bits. DynamicBitSetUnmanaged depends on its padding bits being zeroed as stated in the 'masks' field's doc comments. but setAll() was setting all masks, including the padding, to ones.
travisstaloch
force-pushed
the
dyn-bitset-fixes
branch
from
495ff99
to
48c3f2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDITED
closes #19933
This patch makes setAll() preserve padding bits.
DynamicBitSetUnmanaged depends on its padding bits being zeroed as
stated in the 'masks' field's doc comments. but setAll() was setting
all masks, including the padding, to ones.